You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2025/12/09 01:20:44 UTC
[PR] GH-48404: [Python] Add tests to to_table(filter=...) to reject a boolean expr [arrow]
HyukjinKwon opened a new pull request, #48405:
URL: https://github.com/apache/arrow/pull/48405
### Rationale for this change
- In order to remove the legacy TODO (from https://github.com/apache/arrow/commit/9cb49f3d34dde8d28ac2eb921c4540eada2b19a2)
- To test non-boolean expressions to be rejected in the filter
### What changes are included in this PR?
Added a couple of tests for non-boolean expressions at filter in to_table
### Are these changes tested?
Yes, locally via `pytest pyarrow/tests/test_dataset.py`.
### Are there any user-facing changes?
No, test-only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48404: [Python] Add tests to to_table(filter=...) to reject a boolean expr [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #48405:
URL: https://github.com/apache/arrow/pull/48405#issuecomment-3684833746
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 16023ed5cf6cfab7853ef49f50bed20ec799e9d9.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/58759950110) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48404: [Python] Add tests to to_table(filter=...) to reject a boolean expr [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #48405:
URL: https://github.com/apache/arrow/pull/48405#issuecomment-3629772426
:warning: GitHub issue #48404 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48404: [Python] Add tests to to_table(filter=...) to reject a boolean expr [arrow]
Posted by "adamreeve (via GitHub)" <gi...@apache.org>.
adamreeve merged PR #48405:
URL: https://github.com/apache/arrow/pull/48405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org