[GitHub] [netbeans] BradWalker commented on pull request #3656: Clean up the use of deprecated numeric constructors

[GitBox <gi...@apache.org>]

BradWalker commented on pull request #3656:
URL: https://github.com/apache/netbeans/pull/3656#issuecomment-1048054349


   > hi Brad, the current code inspection in NB for this is not optimal.
   
   I fixed the cases where the code should be calling `parseInt()` instead of `valueOf()`. 
   
   > There is a PR in queue which attempts to fix some of it #3240
   
   I looked at this. My efforts stem from trying to reduce the warning messages. This PR #3240 , while admirable, are more comprehensive than what I'm proposing.
   
   > @lkishalmi has also a PR here #2498 which attempts the same cleanup. I don't know the state of it, maybe he can comment.
   
   I looked at the work he did and I'm happy to take it over if that helps. But, the work that @lkishalmi  was doing was really more comprehensive than what I was trying to do.
   
   I'm simply trying to keep my changes "small" and self contained. This way the impact is very minimal.
   
   @mbien , how do  the changes look now?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists