You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shai Erera (JIRA)" <ji...@apache.org> on 2010/02/23 14:36:27 UTC

[jira] Created: (LUCENE-2281) Add doBeforeFlush to IndexWriter

Add doBeforeFlush to IndexWriter
--------------------------------

                 Key: LUCENE-2281
                 URL: https://issues.apache.org/jira/browse/LUCENE-2281
             Project: Lucene - Java
          Issue Type: Improvement
          Components: Index
            Reporter: Shai Erera
             Fix For: 3.1


IndexWriter has doAfterFlush which can be overridden by extensions in order to perform operations after flush has been called. Since flush is final, one can only override doAfterFlush. This issue will handle two things:
# Make doAfterFlush protected, instead of package-private, to allow for easier extendability of IW.
# Add doBeforeFlush which will be called by flush before it starts, to allow extensions to perform any operations before flush begings.

Will post a patch shortly.

BTW, any chance to get it out in 3.0.1?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Assigned: (LUCENE-2281) Add doBeforeFlush to IndexWriter

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless reassigned LUCENE-2281:
------------------------------------------

    Assignee: Michael McCandless

> Add doBeforeFlush to IndexWriter
> --------------------------------
>
>                 Key: LUCENE-2281
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2281
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Shai Erera
>            Assignee: Michael McCandless
>             Fix For: 3.1
>
>         Attachments: LUCENE-2281.patch
>
>
> IndexWriter has doAfterFlush which can be overridden by extensions in order to perform operations after flush has been called. Since flush is final, one can only override doAfterFlush. This issue will handle two things:
> # Make doAfterFlush protected, instead of package-private, to allow for easier extendability of IW.
> # Add doBeforeFlush which will be called by flush before it starts, to allow extensions to perform any operations before flush begings.
> Will post a patch shortly.
> BTW, any chance to get it out in 3.0.1?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-2281) Add doBeforeFlush to IndexWriter

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless resolved LUCENE-2281.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 3.0.1

Thanks Shai!

> Add doBeforeFlush to IndexWriter
> --------------------------------
>
>                 Key: LUCENE-2281
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2281
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Shai Erera
>            Assignee: Michael McCandless
>             Fix For: 3.0.1, 3.1
>
>         Attachments: LUCENE-2281.patch
>
>
> IndexWriter has doAfterFlush which can be overridden by extensions in order to perform operations after flush has been called. Since flush is final, one can only override doAfterFlush. This issue will handle two things:
> # Make doAfterFlush protected, instead of package-private, to allow for easier extendability of IW.
> # Add doBeforeFlush which will be called by flush before it starts, to allow extensions to perform any operations before flush begings.
> Will post a patch shortly.
> BTW, any chance to get it out in 3.0.1?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-2281) Add doBeforeFlush to IndexWriter

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837284#action_12837284 ] 

Michael McCandless commented on LUCENE-2281:
--------------------------------------------

Patch looks good... thanks Shai!

I think it's fine to backport to 3.0.x (trivial change), but, the 3.0.1 train has likely already left the building -- we've voting now (take 2) on the artifacts.  Maybe I'll backport and if we end up re-spinning it'll be in 3.0.1?  Else 3.0.2...

> Add doBeforeFlush to IndexWriter
> --------------------------------
>
>                 Key: LUCENE-2281
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2281
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Shai Erera
>             Fix For: 3.1
>
>         Attachments: LUCENE-2281.patch
>
>
> IndexWriter has doAfterFlush which can be overridden by extensions in order to perform operations after flush has been called. Since flush is final, one can only override doAfterFlush. This issue will handle two things:
> # Make doAfterFlush protected, instead of package-private, to allow for easier extendability of IW.
> # Add doBeforeFlush which will be called by flush before it starts, to allow extensions to perform any operations before flush begings.
> Will post a patch shortly.
> BTW, any chance to get it out in 3.0.1?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-2281) Add doBeforeFlush to IndexWriter

Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-2281:
----------------------------------

    Fix Version/s: 3.0.2

> Add doBeforeFlush to IndexWriter
> --------------------------------
>
>                 Key: LUCENE-2281
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2281
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Shai Erera
>            Assignee: Michael McCandless
>             Fix For: 3.0.2, 3.1
>
>         Attachments: LUCENE-2281.patch
>
>
> IndexWriter has doAfterFlush which can be overridden by extensions in order to perform operations after flush has been called. Since flush is final, one can only override doAfterFlush. This issue will handle two things:
> # Make doAfterFlush protected, instead of package-private, to allow for easier extendability of IW.
> # Add doBeforeFlush which will be called by flush before it starts, to allow extensions to perform any operations before flush begings.
> Will post a patch shortly.
> BTW, any chance to get it out in 3.0.1?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-2281) Add doBeforeFlush to IndexWriter

Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shai Erera updated LUCENE-2281:
-------------------------------

    Attachment: LUCENE-2281.patch

* Added doBeforeFlush + call to it in doFlushInternal
* Changed doAfterFlush to protected
* Renamed testDoAfterFlush to testDoBeforeAfterFlush in TestIndexWriter (also fixed a bug in the test).

I think this is ready for commit. Would be great if it can go out in 3.0.1 as well

> Add doBeforeFlush to IndexWriter
> --------------------------------
>
>                 Key: LUCENE-2281
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2281
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Shai Erera
>             Fix For: 3.1
>
>         Attachments: LUCENE-2281.patch
>
>
> IndexWriter has doAfterFlush which can be overridden by extensions in order to perform operations after flush has been called. Since flush is final, one can only override doAfterFlush. This issue will handle two things:
> # Make doAfterFlush protected, instead of package-private, to allow for easier extendability of IW.
> # Add doBeforeFlush which will be called by flush before it starts, to allow extensions to perform any operations before flush begings.
> Will post a patch shortly.
> BTW, any chance to get it out in 3.0.1?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-2281) Add doBeforeFlush to IndexWriter

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-2281:
---------------------------------------

    Fix Version/s:     (was: 3.0.1)

Woops, not on 3.0.1 (likely).

> Add doBeforeFlush to IndexWriter
> --------------------------------
>
>                 Key: LUCENE-2281
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2281
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Shai Erera
>            Assignee: Michael McCandless
>             Fix For: 3.1
>
>         Attachments: LUCENE-2281.patch
>
>
> IndexWriter has doAfterFlush which can be overridden by extensions in order to perform operations after flush has been called. Since flush is final, one can only override doAfterFlush. This issue will handle two things:
> # Make doAfterFlush protected, instead of package-private, to allow for easier extendability of IW.
> # Add doBeforeFlush which will be called by flush before it starts, to allow extensions to perform any operations before flush begings.
> Will post a patch shortly.
> BTW, any chance to get it out in 3.0.1?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org