[GitHub] [calcite] zoudan commented on a diff in pull request #3128: [CALCITE-5606] Add SqlLibrary.ALL and change the library of TANH, COSH, SINH to it

["zoudan (via GitHub)" <gi...@apache.org>]

zoudan commented on code in PR #3128:
URL: https://github.com/apache/calcite/pull/3128#discussion_r1160681642


##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibrary.java:
##########
@@ -94,11 +97,21 @@ public enum SqlLibrary {
   /** Parses a comma-separated string such as "standard,oracle". */
   public static List<SqlLibrary> parse(String libraryNameList) {
     final ImmutableList.Builder<SqlLibrary> list = ImmutableList.builder();
-    for (String libraryName : libraryNameList.split(",")) {
-      SqlLibrary library =
-          requireNonNull(SqlLibrary.of(libraryName),
-              () -> "library does not exist: " + libraryName);
-      list.add(library);
+    List<String> libList = Arrays.asList(libraryNameList.split(","));

Review Comment:
   Hi @julianhyde, may I ask if you have time to review this PR, thanks very much



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org