You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/09/14 18:09:22 UTC
[GitHub] [lucene-solr] vigyasharma opened a new pull request #2573: LUCENE-10008: Respect ignoreCase flag in CommonGramsFilterFactory
vigyasharma opened a new pull request #2573:
URL: https://github.com/apache/lucene-solr/pull/2573
_Backporting a bug fix pushed into `apache/lucene:main` as part of this PR - https://github.com/apache/lucene/pull/188_
## Description
`CommonGramsFilterFactory` should respect the ignoreCase flag passed in args even when the default stop word set is used. It currently ignores the flag if `commonWordFiles` are not specified.
## Solution
Ensure the flag is respected in even when default stop word set is used.
## Tests
Added test to ensure that bigrams get constructed with common words that are not in lower case, when `ignoreCase` is passed as `true` to the `CommonGramsFilterFactory`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2573: LUCENE-10008: Respect ignoreCase flag in CommonGramsFilterFactory
Posted by GitBox <gi...@apache.org>.
mikemccand commented on a change in pull request #2573:
URL: https://github.com/apache/lucene-solr/pull/2573#discussion_r722297634
##########
File path: lucene/CHANGES.txt
##########
@@ -648,6 +648,8 @@ Optimizations
Bug Fixes
---------------------
+* LUCENE-10008: Respect ignoreCase in CommonGramsFilterFactory (Vigya Sharma)
Review comment:
Whoa, this is in the wrong (Lucene 8.6.0) section of CHANGES!
Since the 8.10 bits have already been set free, can you move this to the new 8.11 section?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mikemccand merged pull request #2573: LUCENE-10008: Respect ignoreCase flag in CommonGramsFilterFactory
Posted by GitBox <gi...@apache.org>.
mikemccand merged pull request #2573:
URL: https://github.com/apache/lucene-solr/pull/2573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] vigyasharma commented on a change in pull request #2573: LUCENE-10008: Respect ignoreCase flag in CommonGramsFilterFactory
Posted by GitBox <gi...@apache.org>.
vigyasharma commented on a change in pull request #2573:
URL: https://github.com/apache/lucene-solr/pull/2573#discussion_r731346908
##########
File path: lucene/CHANGES.txt
##########
@@ -648,6 +648,8 @@ Optimizations
Bug Fixes
---------------------
+* LUCENE-10008: Respect ignoreCase in CommonGramsFilterFactory (Vigya Sharma)
Review comment:
Oops, my bad. Thanks for checking this Mike. Moved this line to 8.11 section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org