[GitHub] [ignite] Sega76 commented on a change in pull request #9824: IGNITE-13389: Append additional settings to obtain full stack trace on thin client side if an error occurs on server side.

[GitBox <gi...@apache.org>]

Sega76 commented on a change in pull request #9824:
URL: https://github.com/apache/ignite/pull/9824#discussion_r806312613



##########
File path: modules/core/src/main/java/org/apache/ignite/configuration/DistributedThinClientConfiguration.java
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.configuration;

Review comment:
       moved it to org.apache.ignite.internal.processors.configuration.distributed

##########
File path: modules/core/src/main/java/org/apache/ignite/configuration/ThinClientConfiguration.java
##########
@@ -97,6 +101,20 @@ public ThinClientConfiguration setMaxActiveComputeTasksPerConnection(int maxActi
         return this;
     }
 
+    /**
+     * @return If {@code true} sends full stack into client side.
+     */
+    public boolean showFullStackOnClientSide() {
+        return showFullStack;
+    }
+
+    /**
+     * @param showFullStack If {@code true} sends full stack into client side.
+     */
+    public void showFullStackOnClientSide(boolean showFullStack) {

Review comment:
       done

##########
File path: modules/core/src/main/java/org/apache/ignite/configuration/ThinClientConfiguration.java
##########
@@ -97,6 +101,20 @@ public ThinClientConfiguration setMaxActiveComputeTasksPerConnection(int maxActi
         return this;
     }
 
+    /**
+     * @return If {@code true} sends full stack into client side.
+     */
+    public boolean showFullStackOnClientSide() {

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org