svn commit: r1902927 - in /poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel: TestXWPFDocument.java TestXWPFPictureData.java

[fa...@apache.org]

Author: fanningpj
Date: Thu Jul 21 21:40:32 2022
New Revision: 1902927

URL: http://svn.apache.org/viewvc?rev=1902927&view=rev
Log:
add tests

Modified:
    poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFDocument.java
    poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFPictureData.java

Modified: poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFDocument.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFDocument.java?rev=1902927&r1=1902926&r2=1902927&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFDocument.java (original)
+++ poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFDocument.java Thu Jul 21 21:40:32 2022
@@ -17,6 +17,7 @@
 
 package org.apache.poi.xwpf.usermodel;
 
+import static org.junit.jupiter.api.Assertions.assertArrayEquals;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -32,6 +33,7 @@ import java.util.List;
 import java.util.Optional;
 
 import org.apache.poi.POIDataSamples;
+import org.apache.poi.common.usermodel.PictureType;
 import org.apache.poi.ooxml.POIXMLDocumentPart;
 import org.apache.poi.ooxml.POIXMLProperties;
 import org.apache.poi.openxml4j.exceptions.InvalidFormatException;
@@ -153,9 +155,21 @@ public final class TestXWPFDocument {
             assertNotNull(relationById);
             byte[] newJpeg = relationById.getData();
             assertEquals(newJpeg.length, jpeg.length);
-            for (int i = 0; i < jpeg.length; i++) {
-                assertEquals(newJpeg[i], jpeg[i]);
-            }
+            assertArrayEquals(jpeg, newJpeg);
+        }
+    }
+
+    @Test
+    void testAddPicture2() throws IOException, InvalidFormatException {
+        try (XWPFDocument doc = XWPFTestDataSamples.openSampleDocument("sample.docx")) {
+            byte[] data = XWPFTestDataSamples.getImage("nature1.png");
+            String relationId = doc.addPictureData(data, PictureType.PNG);
+
+            XWPFPictureData relationById = (XWPFPictureData) doc.getRelationById(relationId);
+            assertNotNull(relationById);
+            byte[] newData = relationById.getData();
+            assertEquals(newData.length, data.length);
+            assertArrayEquals(data, newData);
         }
     }
 

Modified: poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFPictureData.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFPictureData.java?rev=1902927&r1=1902926&r2=1902927&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFPictureData.java (original)
+++ poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFPictureData.java Thu Jul 21 21:40:32 2022
@@ -27,6 +27,7 @@ import java.io.ByteArrayInputStream;
 import java.io.IOException;
 import java.util.List;
 
+import org.apache.poi.common.usermodel.PictureType;
 import org.apache.poi.openxml4j.exceptions.InvalidFormatException;
 import org.apache.poi.openxml4j.opc.PackageRelationship;
 import org.apache.poi.xssf.usermodel.XSSFRelation;
@@ -59,6 +60,17 @@ class TestXWPFPictureData {
             assertNotNull(pict);
             assertEquals("jpeg", pict.suggestFileExtension());
             assertArrayEquals(pictureData, pict.getData());
+
+            byte[] pictureData2 = XWPFTestDataSamples.getImage("nature1.png");
+
+            String relationId2 = sampleDoc.addPictureData(pictureData2, PictureType.PNG);
+            assertNotEquals(relationId, relationId2);
+            // picture list was updated
+            assertEquals(num + 2, pictures.size());
+            XWPFPictureData pict2 = (XWPFPictureData) sampleDoc.getRelationById(relationId2);
+            assertNotNull(pict2);
+            assertEquals("png", pict2.suggestFileExtension());
+            assertArrayEquals(pictureData2, pict2.getData());
         }
     }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org