You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/11/08 09:29:08 UTC

[GitHub] [cloudstack] rp- opened a new pull request #5672: ui-primary-storage: hide provider if Linstor protocol

rp- opened a new pull request #5672:
URL: https://github.com/apache/cloudstack/pull/5672


   ### Description
   If Linstor protocol is selected it makes no sense to show other
   providers as Linstor only works with the Linstor provider.
   
   This was removed with the fix for #5613, that probably resulted from a
   bad merge resolving from my part.
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   Clicked through local served vui ui -> add primary storage
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #5672: ui-primary-storage: hide provider if Linstor protocol

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5672:
URL: https://github.com/apache/cloudstack/pull/5672


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5672: ui-primary-storage: hide provider if Linstor protocol

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5672:
URL: https://github.com/apache/cloudstack/pull/5672#issuecomment-966929860


   @GabrielBrascher a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #5672: ui-primary-storage: hide provider if Linstor protocol

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #5672:
URL: https://github.com/apache/cloudstack/pull/5672#issuecomment-966928819


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5672: ui-primary-storage: hide provider if Linstor protocol

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5672:
URL: https://github.com/apache/cloudstack/pull/5672#issuecomment-966932503


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5672 (SL-JID-820)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rp- commented on pull request #5672: ui-primary-storage: hide provider if Linstor protocol

Posted by GitBox <gi...@apache.org>.
rp- commented on pull request #5672:
URL: https://github.com/apache/cloudstack/pull/5672#issuecomment-964066164


   I added another fix for the setup-wizard, which didn't set the correct provider for Linstor and would have failed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org