You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/07/11 00:17:15 UTC

Review Request 71052: Added a TODO to add resources breakdowns to v1 GET_ROLES.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71052/
-----------------------------------------------------------

Review request for mesos, Andrei Sekretenko and Meng Zhu.


Repository: mesos


Description
-------

Added a TODO to add resources breakdowns to v1 GET_ROLES.


Diffs
-----

  include/mesos/mesos.proto c4dd0dee0a924351d2b3bb65f2e9cdeb1967e720 
  include/mesos/v1/mesos.proto 158db3501e84be7f4ed504e9a484b158d13a17e3 


Diff: https://reviews.apache.org/r/71052/diff/1/


Testing
-------

make check


Thanks,

Benjamin Mahler


Re: Review Request 71052: Added a TODO to add resources breakdowns to v1 GET_ROLES.

Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71052/#review216512
-----------------------------------------------------------


Ship it!




Ship It!

- Meng Zhu


On July 10, 2019, 5:17 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71052/
> -----------------------------------------------------------
> 
> (Updated July 10, 2019, 5:17 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a TODO to add resources breakdowns to v1 GET_ROLES.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto c4dd0dee0a924351d2b3bb65f2e9cdeb1967e720 
>   include/mesos/v1/mesos.proto 158db3501e84be7f4ed504e9a484b158d13a17e3 
> 
> 
> Diff: https://reviews.apache.org/r/71052/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>