You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Alex Boisvert (JIRA)" <ji...@apache.org> on 2008/09/22 22:47:44 UTC
[jira] Created: (BUILDR-150) Upgrade to JMock 2.5.1
Upgrade to JMock 2.5.1
----------------------
Key: BUILDR-150
URL: https://issues.apache.org/jira/browse/BUILDR-150
Project: Buildr
Issue Type: Task
Components: Test frameworks
Affects Versions: 1.3.2
Reporter: Alex Boisvert
Assignee: Alex Boisvert
Fix For: 1.3.3
As sent on the buildr-user and buildr-dev mailing lists:
http://mail-archives.apache.org/mod_mbox/incubator-buildr-dev/200805.mbox/%3C5582dd3b0805240830l2457cbdcj52d6efc37f1ec74c@mail.gmail.com%3E
While looking into Scala testing, I noticed we're still using JMock 1 (1.2.0) as default. Would anybody oppose upgrading to JMock 2 (2.4.0) by default? [Ed. note: JMock 2.5.1 as of September 22nd, 2008]
JMock 2 features additional and cleaner APIs, but isn't 100% backward compatible with JMock 1. It also requires Java 1.5+.
The main reason I'm asking is because ScalaTest and Scala Specs rely on JMock 2. We could override the defaults for Scala projects but I figured it would be better to have consistent defaults between Java/Scala.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-150) Upgrade to JMock 2.5.1
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Boisvert resolved BUILDR-150.
----------------------------------
Resolution: Fixed
Patch applied. Thanks Antoine!
Sending CHANGELOG
Sending lib/buildr/java/tests.rb
Sending spec/java/bdd_spec.rb
Sending spec/java/tests_spec.rb
Transmitting file data ....
Committed revision 917191.
> Upgrade to JMock 2.5.1
> ----------------------
>
> Key: BUILDR-150
> URL: https://issues.apache.org/jira/browse/BUILDR-150
> Project: Buildr
> Issue Type: Task
> Components: Test frameworks
> Affects Versions: 1.3.2
> Reporter: Alex Boisvert
> Assignee: Alex Boisvert
> Fix For: 1.4
>
> Attachments: BUILDR-150.txt
>
>
> As sent on the buildr-user and buildr-dev mailing lists:
> http://mail-archives.apache.org/mod_mbox/incubator-buildr-dev/200805.mbox/%3C5582dd3b0805240830l2457cbdcj52d6efc37f1ec74c@mail.gmail.com%3E
> While looking into Scala testing, I noticed we're still using JMock 1 (1.2.0) as default. Would anybody oppose upgrading to JMock 2 (2.4.0) by default? [Ed. note: JMock 2.5.1 as of September 22nd, 2008]
> JMock 2 features additional and cleaner APIs, but isn't 100% backward compatible with JMock 1. It also requires Java 1.5+.
> The main reason I'm asking is because ScalaTest and Scala Specs rely on JMock 2. We could override the defaults for Scala projects but I figured it would be better to have consistent defaults between Java/Scala.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-150) Upgrade to JMock 2.5.1
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Boisvert updated BUILDR-150:
---------------------------------
Fix Version/s: (was: 1.3.3)
1.4
> Upgrade to JMock 2.5.1
> ----------------------
>
> Key: BUILDR-150
> URL: https://issues.apache.org/jira/browse/BUILDR-150
> Project: Buildr
> Issue Type: Task
> Components: Test frameworks
> Affects Versions: 1.3.2
> Reporter: Alex Boisvert
> Assignee: Alex Boisvert
> Fix For: 1.4
>
>
> As sent on the buildr-user and buildr-dev mailing lists:
> http://mail-archives.apache.org/mod_mbox/incubator-buildr-dev/200805.mbox/%3C5582dd3b0805240830l2457cbdcj52d6efc37f1ec74c@mail.gmail.com%3E
> While looking into Scala testing, I noticed we're still using JMock 1 (1.2.0) as default. Would anybody oppose upgrading to JMock 2 (2.4.0) by default? [Ed. note: JMock 2.5.1 as of September 22nd, 2008]
> JMock 2 features additional and cleaner APIs, but isn't 100% backward compatible with JMock 1. It also requires Java 1.5+.
> The main reason I'm asking is because ScalaTest and Scala Specs rely on JMock 2. We could override the defaults for Scala projects but I figured it would be better to have consistent defaults between Java/Scala.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-150) Upgrade to JMock 2.5.1
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839384#action_12839384 ]
Antoine Toulme commented on BUILDR-150:
---------------------------------------
Note that my patch passes the specs, and just does the minimum described by Alexis. I guess actually using jmock in a real world project would prove whether something is missing.
> Upgrade to JMock 2.5.1
> ----------------------
>
> Key: BUILDR-150
> URL: https://issues.apache.org/jira/browse/BUILDR-150
> Project: Buildr
> Issue Type: Task
> Components: Test frameworks
> Affects Versions: 1.3.2
> Reporter: Alex Boisvert
> Assignee: Alex Boisvert
> Fix For: 1.4
>
> Attachments: BUILDR-150.txt
>
>
> As sent on the buildr-user and buildr-dev mailing lists:
> http://mail-archives.apache.org/mod_mbox/incubator-buildr-dev/200805.mbox/%3C5582dd3b0805240830l2457cbdcj52d6efc37f1ec74c@mail.gmail.com%3E
> While looking into Scala testing, I noticed we're still using JMock 1 (1.2.0) as default. Would anybody oppose upgrading to JMock 2 (2.4.0) by default? [Ed. note: JMock 2.5.1 as of September 22nd, 2008]
> JMock 2 features additional and cleaner APIs, but isn't 100% backward compatible with JMock 1. It also requires Java 1.5+.
> The main reason I'm asking is because ScalaTest and Scala Specs rely on JMock 2. We could override the defaults for Scala projects but I figured it would be better to have consistent defaults between Java/Scala.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-150) Upgrade to JMock 2.5.1
Posted by "Martin Grotzke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701263#action_12701263 ]
Martin Grotzke commented on BUILDR-150:
---------------------------------------
I just found out that also jmock-1 supports class proxies using cglib: http://www.jmock.org/jmock1-cglib.html
> Upgrade to JMock 2.5.1
> ----------------------
>
> Key: BUILDR-150
> URL: https://issues.apache.org/jira/browse/BUILDR-150
> Project: Buildr
> Issue Type: Task
> Components: Test frameworks
> Affects Versions: 1.3.2
> Reporter: Alex Boisvert
> Assignee: Alex Boisvert
> Fix For: 1.4
>
>
> As sent on the buildr-user and buildr-dev mailing lists:
> http://mail-archives.apache.org/mod_mbox/incubator-buildr-dev/200805.mbox/%3C5582dd3b0805240830l2457cbdcj52d6efc37f1ec74c@mail.gmail.com%3E
> While looking into Scala testing, I noticed we're still using JMock 1 (1.2.0) as default. Would anybody oppose upgrading to JMock 2 (2.4.0) by default? [Ed. note: JMock 2.5.1 as of September 22nd, 2008]
> JMock 2 features additional and cleaner APIs, but isn't 100% backward compatible with JMock 1. It also requires Java 1.5+.
> The main reason I'm asking is because ScalaTest and Scala Specs rely on JMock 2. We could override the defaults for Scala projects but I figured it would be better to have consistent defaults between Java/Scala.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-150) Upgrade to JMock 2.5.1
Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835311#action_12835311 ]
Alexis Midon commented on BUILDR-150:
-------------------------------------
The upgrade to jmock 2.5.1 requires to add the following dependencies:
org.jmock:jmock:jar:2.5.1
org.jmock:jmock-junit4:jar:2.5.1 or org.jmock:jmock-junit3:jar:2.5.1
org.hamcrest:hamcrest-core:jar:1.1
org.hamcrest:hamcrest-library:jar:1.1
The jmock-junit artifact id depends on the junit version: jmock-junit4 or jmock-junit3. So the patch should check junit version.
Since version 1.2, the group id has changed from 'jmock' to 'org:jmock'. So the traditional way to customize versions does not work.
> Upgrade to JMock 2.5.1
> ----------------------
>
> Key: BUILDR-150
> URL: https://issues.apache.org/jira/browse/BUILDR-150
> Project: Buildr
> Issue Type: Task
> Components: Test frameworks
> Affects Versions: 1.3.2
> Reporter: Alex Boisvert
> Assignee: Alex Boisvert
> Fix For: 1.4
>
>
> As sent on the buildr-user and buildr-dev mailing lists:
> http://mail-archives.apache.org/mod_mbox/incubator-buildr-dev/200805.mbox/%3C5582dd3b0805240830l2457cbdcj52d6efc37f1ec74c@mail.gmail.com%3E
> While looking into Scala testing, I noticed we're still using JMock 1 (1.2.0) as default. Would anybody oppose upgrading to JMock 2 (2.4.0) by default? [Ed. note: JMock 2.5.1 as of September 22nd, 2008]
> JMock 2 features additional and cleaner APIs, but isn't 100% backward compatible with JMock 1. It also requires Java 1.5+.
> The main reason I'm asking is because ScalaTest and Scala Specs rely on JMock 2. We could override the defaults for Scala projects but I figured it would be better to have consistent defaults between Java/Scala.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-150) Upgrade to JMock 2.5.1
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme updated BUILDR-150:
----------------------------------
Attachment: BUILDR-150.txt
Here is a patch to support JMock <= 2.x
> Upgrade to JMock 2.5.1
> ----------------------
>
> Key: BUILDR-150
> URL: https://issues.apache.org/jira/browse/BUILDR-150
> Project: Buildr
> Issue Type: Task
> Components: Test frameworks
> Affects Versions: 1.3.2
> Reporter: Alex Boisvert
> Assignee: Alex Boisvert
> Fix For: 1.4
>
> Attachments: BUILDR-150.txt
>
>
> As sent on the buildr-user and buildr-dev mailing lists:
> http://mail-archives.apache.org/mod_mbox/incubator-buildr-dev/200805.mbox/%3C5582dd3b0805240830l2457cbdcj52d6efc37f1ec74c@mail.gmail.com%3E
> While looking into Scala testing, I noticed we're still using JMock 1 (1.2.0) as default. Would anybody oppose upgrading to JMock 2 (2.4.0) by default? [Ed. note: JMock 2.5.1 as of September 22nd, 2008]
> JMock 2 features additional and cleaner APIs, but isn't 100% backward compatible with JMock 1. It also requires Java 1.5+.
> The main reason I'm asking is because ScalaTest and Scala Specs rely on JMock 2. We could override the defaults for Scala projects but I figured it would be better to have consistent defaults between Java/Scala.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-150) Upgrade to JMock 2.5.1
Posted by "Martin Grotzke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701257#action_12701257 ]
Martin Grotzke commented on BUILDR-150:
---------------------------------------
It would be good if the user might specify the jmock dependency (the new groupId/artifactId is 'org.jmock:jmock-junit4').
I need jmock 2 as this can proxy classes, while jmock 1 only can proxy interfaces.
> Upgrade to JMock 2.5.1
> ----------------------
>
> Key: BUILDR-150
> URL: https://issues.apache.org/jira/browse/BUILDR-150
> Project: Buildr
> Issue Type: Task
> Components: Test frameworks
> Affects Versions: 1.3.2
> Reporter: Alex Boisvert
> Assignee: Alex Boisvert
> Fix For: 1.4
>
>
> As sent on the buildr-user and buildr-dev mailing lists:
> http://mail-archives.apache.org/mod_mbox/incubator-buildr-dev/200805.mbox/%3C5582dd3b0805240830l2457cbdcj52d6efc37f1ec74c@mail.gmail.com%3E
> While looking into Scala testing, I noticed we're still using JMock 1 (1.2.0) as default. Would anybody oppose upgrading to JMock 2 (2.4.0) by default? [Ed. note: JMock 2.5.1 as of September 22nd, 2008]
> JMock 2 features additional and cleaner APIs, but isn't 100% backward compatible with JMock 1. It also requires Java 1.5+.
> The main reason I'm asking is because ScalaTest and Scala Specs rely on JMock 2. We could override the defaults for Scala projects but I figured it would be better to have consistent defaults between Java/Scala.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.