You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "sunbufu (GitHub)" <gi...@apache.org> on 2019/01/25 06:46:06 UTC
[GitHub] [incubator-dubbo-ops] sunbufu opened pull request #279: unit
test for LoadBalanceController
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/279 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] kezhenxu94 commented on pull request
#279: unit test for LoadBalanceController
Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
Why not specify the return type as `Boolean.class`? Then there is no need to use `ObjectMapper`, you can use `responseEntity.getBody()`
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/279 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] kezhenxu94 commented on pull request
#279: unit test for LoadBalanceController
Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
Same as above
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/279 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] kezhenxu94 commented on pull request
#279: unit test for LoadBalanceController
Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
Why not specify the return type as List.class? Then there is no need to use ObjectMapper, you can use responseEntity.getBody()
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/279 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] nzomkxia commented on issue #279: unit
test for LoadBalanceController
Posted by "nzomkxia (GitHub)" <gi...@apache.org>.
please check travis CI
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/279 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] kezhenxu94 commented on pull request
#279: unit test for LoadBalanceController
Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
Why not specify the return type as Boolean.class? Then there is no need to use ObjectMapper, you can use responseEntity.getBody()
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/279 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] nzomkxia closed pull request #279:
unit test for LoadBalanceController
Posted by "nzomkxia (GitHub)" <gi...@apache.org>.
[ pull request closed by nzomkxia ]
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/279 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] kezhenxu94 commented on pull request
#279: unit test for LoadBalanceController
Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
Why not specify the return type as Boolean.class? Then there is no need to use ObjectMapper, you can use responseEntity.getBody()
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/279 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org