You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/30 16:08:28 UTC

[GitHub] [superset] hughhhh commented on a change in pull request #16875: refactor(DB Connections): Build Snowflake Dynamic Form

hughhhh commented on a change in pull request #16875:
URL: https://github.com/apache/superset/pull/16875#discussion_r719556095



##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
##########
@@ -55,7 +55,7 @@ import {
 import Loading from 'src/components/Loading';
 import ExtraOptions from './ExtraOptions';
 import SqlAlchemyForm from './SqlAlchemyForm';
-import DatabaseConnectionForm from './DatabaseConnectionForm';
+import DatabaseConnectionForm from './DatabaseConnectionForm/DatabaseConnectionForm';

Review comment:
       Rename `/DatabaseConnectionForm/DatabaseConnectionForm` to `/DatabaseConnectionForm/index.tsx` so we can just import like this:
   ```
   import DatabaseConnectionForm from './DatabaseConnectionForm/DatabaseConnectionForm';
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org