You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/06/20 19:02:57 UTC

[kudu-CR] Allow crcutil* symbols in the client 

David Ribeiro Alves has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3412

Change subject: Allow crcutil* symbols in the client
......................................................................

Allow crcutil* symbols in the client

A previous patch moved PB tracing utilities into pb_util.cc/h but
in order to use these in the client (in RcpController, follow up patch)
the crcutil* symbols need to be allowed.

Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
---
M src/kudu/client/symbols.map
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/3412/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>

[kudu-CR] Allow crcutil* symbols in the client

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: Allow crcutil* symbols in the client
......................................................................


Patch Set 3:

Looks good, but this needs to be part of whichever patch added a reference to pb_util from within the client, otherwise that patch will fail with a test failure in client_symbol-test.sh.

-- 
To view, visit http://gerrit.cloudera.org:8080/3412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Allow crcutil* symbols in the client

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: Allow crcutil* symbols in the client
......................................................................


Patch Set 3:

I guess I could, but I usually don't like to have random, apparently unrelated, changes in patches and I figured it would be best to do the change elsewhere and explain it properly. I guess I can squash if you feel strongly, but historically I think we've posted side patches for things like this.

-- 
To view, visit http://gerrit.cloudera.org:8080/3412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Allow crcutil* symbols in the client

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: Allow crcutil* symbols in the client
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3412/4/src/kudu/client/symbols.map
File src/kudu/client/symbols.map:

Line 32:       # From src/kudu/util/crc.{h,cc}.
That's not quite right, though; these symbols are defined by crcutil in thirdparty. So I would just say:

  # crcutil
  crcutil::*;
  crcutil_interface::*;

That should be good enough to indicate a thirdparty dependency.


-- 
To view, visit http://gerrit.cloudera.org:8080/3412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] Allow crcutil* symbols in the client

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Allow crcutil* symbols in the client
......................................................................


Patch Set 4:

Build Started http://104.196.14.100/job/kudu-gerrit/1900/

-- 
To view, visit http://gerrit.cloudera.org:8080/3412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Allow crcutil* symbols in the client

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: Allow crcutil* symbols in the client
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3412/4/src/kudu/client/symbols.map
File src/kudu/client/symbols.map:

Line 32:       # From src/kudu/util/crc.{h,cc}.
> That's not quite right, though; these symbols are defined by crcutil in thi
honestly not sure what information that is adding, but Done.


-- 
To view, visit http://gerrit.cloudera.org:8080/3412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] Allow crcutil* symbols in the client

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: Allow crcutil* symbols in the client
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3412/3/src/kudu/client/symbols.map
File src/kudu/client/symbols.map:

Line 31:       crcutil::*;
Nit: break this out with an empty line and declare the name of the library that's responsible for these symbols.


-- 
To view, visit http://gerrit.cloudera.org:8080/3412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] Allow crcutil* symbols in the client

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3412

to look at the new patch set (#4).

Change subject: Allow crcutil* symbols in the client
......................................................................

Allow crcutil* symbols in the client

A previous patch moved PB tracing utilities into pb_util.cc/h but
in order to use these in the client (in RcpController, follow up patch)
the crcutil* symbols need to be allowed.

Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
---
M src/kudu/client/symbols.map
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/3412/4
-- 
To view, visit http://gerrit.cloudera.org:8080/3412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Allow crcutil* symbols in the client

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: Allow crcutil* symbols in the client
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3412/4/src/kudu/client/symbols.map
File src/kudu/client/symbols.map:

Line 32:       # crcutil
> honestly not sure what information that is adding, but Done.
You're right, it doesn't add much. I mostly just wanted it separate from the "glog, gflags, and protobuf" block.


-- 
To view, visit http://gerrit.cloudera.org:8080/3412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] Allow crcutil* symbols in the client

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Allow crcutil* symbols in the client
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/1889/

-- 
To view, visit http://gerrit.cloudera.org:8080/3412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Allow crcutil* symbols in the client

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Allow crcutil* symbols in the client
......................................................................


Patch Set 3:

Build Started http://104.196.14.100/job/kudu-gerrit/1892/

-- 
To view, visit http://gerrit.cloudera.org:8080/3412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Allow crcutil* symbols in the client

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: Allow crcutil* symbols in the client
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3412/3/src/kudu/client/symbols.map
File src/kudu/client/symbols.map:

Line 31:       crcutil::*;
> Nit: break this out with an empty line and declare the name of the library 
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] Allow crcutil* symbols in the client

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Allow crcutil* symbols in the client
......................................................................


Patch Set 5:

Build Started http://104.196.14.100/job/kudu-gerrit/1905/

-- 
To view, visit http://gerrit.cloudera.org:8080/3412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Allow crcutil* symbols in the client

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3412

to look at the new patch set (#5).

Change subject: Allow crcutil* symbols in the client
......................................................................

Allow crcutil* symbols in the client

A previous patch moved PB tracing utilities into pb_util.cc/h but
in order to use these in the client (in RcpController, follow up patch)
the crcutil* symbols need to be allowed.

Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
---
M src/kudu/client/symbols.map
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/3412/5
-- 
To view, visit http://gerrit.cloudera.org:8080/3412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Allow crcutil* symbols in the client

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: Allow crcutil* symbols in the client
......................................................................


Patch Set 3:

> don't follow, isn't it ok if it follows this one on the sequence?

Oh, you've ordered it so this one comes first? I see. That's safe. But I think it'd be better to combine them nevertheless, so that it's obvious which code change forced the changes to symbols.map.

-- 
To view, visit http://gerrit.cloudera.org:8080/3412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Allow crcutil* symbols in the client

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Allow crcutil* symbols in the client
......................................................................


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/1891/

-- 
To view, visit http://gerrit.cloudera.org:8080/3412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Allow crcutil* symbols in the client

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.

Change subject: Allow crcutil* symbols in the client
......................................................................


Allow crcutil* symbols in the client

A previous patch moved PB tracing utilities into pb_util.cc/h but
in order to use these in the client (in RcpController, follow up patch)
the crcutil* symbols need to be allowed.

Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
Reviewed-on: http://gerrit.cloudera.org:8080/3412
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/client/symbols.map
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Allow crcutil* symbols in the client

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: Allow crcutil* symbols in the client
......................................................................


Patch Set 3:

don't follow, isn't it ok if it follows this one on the sequence?

-- 
To view, visit http://gerrit.cloudera.org:8080/3412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No