You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Robert Justice (JIRA)" <ji...@apache.org> on 2012/11/16 21:27:13 UTC
[jira] [Commented] (HBASE-5281) Should a failure in creating an
unassigned node abort the master?
[ https://issues.apache.org/jira/browse/HBASE-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499120#comment-13499120 ]
Robert Justice commented on HBASE-5281:
---------------------------------------
Harsh, In discussion with Kevin, this issue appears to still be a problem. The attached code,
if you run the separate method, will crash the master about 50% of the time. Ping me if you have
any questions.
> Should a failure in creating an unassigned node abort the master?
> -----------------------------------------------------------------
>
> Key: HBASE-5281
> URL: https://issues.apache.org/jira/browse/HBASE-5281
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.5
> Reporter: Harsh J
> Assignee: Harsh J
> Fix For: 0.92.1, 0.94.0
>
> Attachments: HBASE-5281.patch
>
>
> In {{AssignmentManager}}'s {{CreateUnassignedAsyncCallback}}, we have the following condition:
> {code}
> if (rc != 0) {
> // Thisis resultcode. If non-zero, need to resubmit.
> LOG.warn("rc != 0 for " + path + " -- retryable connectionloss -- " +
> "FIX see http://wiki.apache.org/hadoop/ZooKeeper/FAQ#A2");
> this.zkw.abort("Connectionloss writing unassigned at " + path +
> ", rc=" + rc, null);
> return;
> }
> {code}
> While a similar structure inside {{ExistsUnassignedAsyncCallback}} (which the above is linked to), does not have such a force abort.
> Do we really require the abort statement here, or can we make do without?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira