[GitHub] [arrow] MarcoGorelli commented on a diff in pull request #14662: GH-31905: [DevTools] Add linting to Cython files

["MarcoGorelli (via GitHub)" <gi...@apache.org>]

MarcoGorelli commented on code in PR #14662:
URL: https://github.com/apache/arrow/pull/14662#discussion_r1118444809


##########
.pre-commit-config.yaml:
##########
@@ -47,3 +47,8 @@ repos:
           - python
         exclude: vendored
         args: [--config, python/setup.cfg]
+  - repo: https://github.com/MarcoGorelli/cython-lint
+    rev: v0.12.4
+    hooks:
+      - id: cython-lint
+        args: [--max-line-length=120]

Review Comment:
   thanks for your reviews
   
   for now I've put the `--no-pycodestyle` flag, which only does the AST checks (e.g. unused variables/imports/dangerous patterns, rather than style nitpicks) - is that OK?
   
   There's hundreds of cases which would need fixing to get under the 88 limit, which at the moment I'm a bit too busy for I'm afraid
   
   Else I'll update with the 88 limit when I get a chance, no worries



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org