You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/05/05 23:33:47 UTC
[GitHub] [incubator-mxnet] mseth10 opened a new pull request #18245: add python3 to run safe_docker_run.py
mseth10 opened a new pull request #18245:
URL: https://github.com/apache/incubator-mxnet/pull/18245
## Description ##
The nightly CD release of docker images currently fails as it runs `safe_docker_run.py` as an executable when it is a python script. This PR fixes that along with a test running the same file.
Here's is the link to the broken CD pipeline:
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/restricted-mxnet-cd%2Fmxnet-cd-release-job/detail/mxnet-cd-release-job/1075/pipeline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18245: add python3 to run safe_docker_run.py
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #18245:
URL: https://github.com/apache/incubator-mxnet/pull/18245#discussion_r420471171
##########
File path: ci/test_safe_docker_run.py
##########
@@ -408,7 +408,7 @@ def wait_for_container(name: str) -> bool:
# to the atexit
for sig in [None, signal.SIGTERM, signal.SIGINT]:
# Execute the safe docker run script in a different process
- proc = subprocess.Popen(['./safe_docker_run.py', "--name", container_name, "ubuntu:18.04", "sleep 10"])
+ proc = subprocess.Popen(['python3 safe_docker_run.py', "--name", container_name, "ubuntu:18.04", "sleep 10"])
Review comment:
May need to separate python3 and the script name into two elements of the list?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on a change in pull request #18245: add python3 to run safe_docker_run.py
Posted by GitBox <gi...@apache.org>.
mseth10 commented on a change in pull request #18245:
URL: https://github.com/apache/incubator-mxnet/pull/18245#discussion_r420472844
##########
File path: ci/test_safe_docker_run.py
##########
@@ -408,7 +408,7 @@ def wait_for_container(name: str) -> bool:
# to the atexit
for sig in [None, signal.SIGTERM, signal.SIGINT]:
# Execute the safe docker run script in a different process
- proc = subprocess.Popen(['./safe_docker_run.py', "--name", container_name, "ubuntu:18.04", "sleep 10"])
+ proc = subprocess.Popen(['python3 safe_docker_run.py', "--name", container_name, "ubuntu:18.04", "sleep 10"])
Review comment:
fixed, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on pull request #18245: add python3 to run safe_docker_run.py
Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #18245:
URL: https://github.com/apache/incubator-mxnet/pull/18245#issuecomment-624505954
@leezu can you please help review and merge this. thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org