You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/26 14:55:31 UTC

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25582: [SPARK-28875][DSTREAMS][SS][TESTS] Add Task retry tests to make sure new consumer used

HeartSaVioR commented on a change in pull request #25582: [SPARK-28875][DSTREAMS][SS][TESTS] Add Task retry tests to make sure new consumer used
URL: https://github.com/apache/spark/pull/25582#discussion_r317643184
 
 

 ##########
 File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaDataConsumer.scala
 ##########
 @@ -78,7 +78,7 @@ private[kafka010] sealed trait KafkaDataConsumer {
   def release(): Unit
 
   /** Reference to the internal implementation that this wrapper delegates to */
-  protected def internalConsumer: InternalKafkaConsumer
+  def internalConsumer: InternalKafkaConsumer
 
 Review comment:
   That's technically `private[kafka010]` as class scope so seems OK.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org