[GitHub] [samza] jia-gao opened a new pull request #1563: SAMZA-2711: Fix flaky TestZkLocalApplicationRunner

[GitBox <gi...@apache.org>]

jia-gao opened a new pull request #1563:
URL: https://github.com/apache/samza/pull/1563


   Issues: 
   TestZkLocalApplicationRunner.shouldStopNewProcessorsJoiningGroupWhenNumContainersIsGreaterThanNumTasks asserts
     A) JobModel generated before and after the addition of appRunner2 should be equal.
     B) Second stream application(appRunner2) should not join the group and process any message.
   
   
   Assertion A is good, but the test can not guarantee Assertion B.
   The reason is that the test kill appRunner1 then kill appRunner2, but after appRunner1 got killed and before appRunner2 gets killed, ZkJobCoordinator could generate a new JobModel with appRunner 2
   That leads to appRunner2 status change from New->Running->SuccessfulFinish
   instead of New->UnsuccessfulFinish, which result in the test failure
   
   Changes: 
       kill appRunner2 and do assertion before kill appRunner1
       
   Tests: ./gradlew build
   API changes: N/A


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] cameronlee314 merged pull request #1563: SAMZA-2711: Fix flaky TestZkLocalApplicationRunner

[GitBox <gi...@apache.org>]

cameronlee314 merged pull request #1563:
URL: https://github.com/apache/samza/pull/1563


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org