[jira] [Commented] (FLINK-9765) Improve CLI responsiveness when cluster is not reachable

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533581#comment-16533581 ] 

ASF GitHub Bot commented on FLINK-9765:
---------------------------------------

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/6265

    [FLINK-9765] [sql-client] Improve CLI responsiveness when cluster is not reachable

    ## What is the purpose of the change
    
    Moves the job cancellation into the final phase of the refresh thread in order to keep the CLI responsive. The result of the cancellation is not used anyway.
    
    ## Brief change log
    
    Moves the job cancellation into the phase of the refresh thread
    
    ## Verifying this change
    
    Manually verified.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not applicable


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-9765

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6265
    
----
commit 8204ae6e2a638b6c9f0d093bcd35b7710b0dbf61
Author: Timo Walther <tw...@...>
Date:   2018-07-05T11:25:28Z

    [FLINK-9765] [sql-client] Improve CLI responsiveness when cluster is not reachable

----


> Improve CLI responsiveness when cluster is not reachable
> --------------------------------------------------------
>
>                 Key: FLINK-9765
>                 URL: https://issues.apache.org/jira/browse/FLINK-9765
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API &amp; SQL
>    Affects Versions: 1.5.0
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>
> If the cluster was not started or is not reachable it takes a long time to cancel a result. This should not affect the main thread. The CLI should be responsive at all times.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)