You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2023/02/09 12:50:41 UTC
[kyuubi] branch branch-1.6 updated: [KYUUBI #4247][FOLLOWUP] Fix `build/mvn` version comparison
This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch branch-1.6
in repository https://gitbox.apache.org/repos/asf/kyuubi.git
The following commit(s) were added to refs/heads/branch-1.6 by this push:
new fa31c19a8 [KYUUBI #4247][FOLLOWUP] Fix `build/mvn` version comparison
fa31c19a8 is described below
commit fa31c19a839d6de979eb876db18d08737c589b28
Author: Cheng Pan <ch...@apache.org>
AuthorDate: Thu Feb 9 20:45:02 2023 +0800
[KYUUBI #4247][FOLLOWUP] Fix `build/mvn` version comparison
### _Why are the changes needed?_
`build/mvn` should download the maven when the local `mvn` version does not match, this corrects the change in #4261
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
Closes #4291 from pan3793/mvn-version.
Closes #4247
42717a73c [Cheng Pan] [KYUUBI #4247][FOLLOWUP] Fix build/mvn version comparison
Authored-by: Cheng Pan <ch...@apache.org>
Signed-off-by: Cheng Pan <ch...@apache.org>
---
build/mvn | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/build/mvn b/build/mvn
index de697f410..67aa02b4f 100755
--- a/build/mvn
+++ b/build/mvn
@@ -76,7 +76,7 @@ install_mvn() {
fi
# See simple version normalization: http://stackoverflow.com/questions/16989598/bash-comparing-version-numbers
function version { echo "$@" | awk -F. '{ printf("%03d%03d%03d\n", $1,$2,$3); }'; }
- if [ $(version $MVN_DETECTED_VERSION) -eq $(version $MVN_VERSION) ]; then
+ if [ $(version $MVN_DETECTED_VERSION) -ne $(version $MVN_VERSION) ]; then
local APACHE_MIRROR=${APACHE_MIRROR:-'https://archive.apache.org/dist/'}
install_app \