You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2015/03/24 14:47:08 UTC
[Bug 7158] New: Issue with wrong X-Spam-Date-of-Scan
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7158
Bug ID: 7158
Summary: Issue with wrong X-Spam-Date-of-Scan
Product: Spamassassin
Version: unspecified
Hardware: Other
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Rules
Assignee: dev@spamassassin.apache.org
Reporter: geoffrey@acyba.com
X-Spam-Date-of-Scan was totally wrong, something like 1965.
I shifted the @_ to correct the problem like said here :
http://www.gossamer-threads.com/lists/spamassassin/users/185212
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7158] Issue with wrong X-Spam-Date-of-Scan
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7158
--- Comment #5 from geoffrey@acyba.com ---
Ok sure, so I correct the patch right now.
Oh and just for my erudition what does pms stand for ? :)
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7158] Issue with wrong X-Spam-Date-of-Scan
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7158
--- Comment #3 from geoffrey@acyba.com ---
I totally agree with you Kevin,
I found many times 'my $pms = shift'
in PerMsgStatus.pm so I tried something similar.
I'm totally not an expert in perl, like I know the very very (very) basics.
So I'm a bit confused to correct the problem.
I searched the calls of the function but they are all empty.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7158] Issue with wrong X-Spam-Date-of-Scan
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7158
--- Comment #11 from geoffrey@acyba.com ---
(In reply to Mark Martinec from comment #10)
> (In reply to Mark Martinec from comment #9)
> > (In reply to Kevin A. McGrail from comment #2)
> > > Just throwing away a parameter seems a hack. I think we need to fix the
> > > calls to the function.
> >
> > Indeed.
> >
> > The Mail::SpamAssassin::Util::time_to_rfc822_date is just a plain
> > subroutine, not a method on the $pms object. Its argument should be
> > a Unix time (integer, seconds), not a $pms followed by a time.
>
> This bug was fixed in Bug 7050:
>
> r1601527 | kb | 2014-06-10 01:17:43 +0200 (Tue, 10 Jun 2014) | 4 lines
> Bug 7050, fix _DATE_ Template Tag. Use anonymous sub, calling
> Util::time_to_rfc822_date() explicitly without any argument.
I still have the problem on my spamassassin and I checked and effectively I
still have the old PerMsgStatus.pm. Do you know when this modification will be
in package for ubuntu ? Since this summer (when the bug was apparently
discovered) I updated several times but still got the bug.
Sorry to bothered you with my imaginary issue :(
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7158] Issue with wrong X-Spam-Date-of-Scan
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7158
--- Comment #8 from geoffrey@acyba.com ---
(In reply to Kevin A. McGrail from comment #6)
> (In reply to geoffrey from comment #5)
> > Ok sure, so I correct the patch right now.
> > Oh and just for my erudition what does pms stand for ? :)
>
> Per Message Status - It's a very core loop in the SA process.
Ok thank you :)
By knowing that I think my correction is wrong. I just renamed the variable but
I think that's not what you said on your previous post ?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7158] Issue with wrong X-Spam-Date-of-Scan
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7158
--- Comment #6 from Kevin A. McGrail <km...@pccc.com> ---
(In reply to geoffrey from comment #5)
> Ok sure, so I correct the patch right now.
> Oh and just for my erudition what does pms stand for ? :)
Per Message Status - It's a very core loop in the SA process.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7158] Issue with wrong X-Spam-Date-of-Scan
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7158
--- Comment #4 from Kevin A. McGrail <km...@pccc.com> ---
I was reading the thread and another patch. my $pms = shift makes sense
because its a standard param.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7158] Issue with wrong X-Spam-Date-of-Scan
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7158
--- Comment #10 from Mark Martinec <Ma...@ijs.si> ---
(In reply to Mark Martinec from comment #9)
> (In reply to Kevin A. McGrail from comment #2)
> > Just throwing away a parameter seems a hack. I think we need to fix the
> > calls to the function.
>
> Indeed.
>
> The Mail::SpamAssassin::Util::time_to_rfc822_date is just a plain
> subroutine, not a method on the $pms object. Its argument should be
> a Unix time (integer, seconds), not a $pms followed by a time.
This bug was fixed in Bug 7050:
r1601527 | kb | 2014-06-10 01:17:43 +0200 (Tue, 10 Jun 2014) | 4 lines
Bug 7050, fix _DATE_ Template Tag. Use anonymous sub, calling
Util::time_to_rfc822_date() explicitly without any argument.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7158] Issue with wrong X-Spam-Date-of-Scan
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7158
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
Status|NEW |RESOLVED
--- Comment #13 from Mark Martinec <Ma...@ijs.si> ---
Duplicate of Bug 7050.
*** This bug has been marked as a duplicate of bug 7050 ***
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7158] Issue with wrong X-Spam-Date-of-Scan
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7158
--- Comment #9 from Mark Martinec <Ma...@ijs.si> ---
(In reply to Kevin A. McGrail from comment #2)
> Just throwing away a parameter seems a hack. I think we need to fix the
> calls to the function.
Indeed.
The Mail::SpamAssassin::Util::time_to_rfc822_date is just a plain
subroutine, not a method on the $pms object. Its argument should be
a Unix time (integer, seconds), not a $pms followed by a time.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7158] Issue with wrong X-Spam-Date-of-Scan
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7158
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|unspecified |3.4.0
Target Milestone|Undefined |3.4.1
--- Comment #12 from Mark Martinec <Ma...@ijs.si> ---
As far as I can tell the bug is in 3.4.0
and is fixed in current trunk - to be released soon as 3.4.1.
> Do you know when this modification will be in package for ubuntu?
No idea. Either persuade them to apply the tiny fix from Bug 7050
into their 3.4.0 package, or wait for the 3.4.1 release and hope
that it tickles down to packages quickly. Another option is
to run trunk code, as many of us do.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7158] Issue with wrong X-Spam-Date-of-Scan
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7158
geoffrey@acyba.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #5288|0 |1
is obsolete| |
--- Comment #7 from geoffrey@acyba.com ---
Created attachment 5289
--> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5289&action=edit
Changed trash variable to pms
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7158] Issue with wrong X-Spam-Date-of-Scan
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7158
--- Comment #14 from geoffrey@acyba.com ---
(In reply to Mark Martinec from comment #12)
> As far as I can tell the bug is in 3.4.0
> and is fixed in current trunk - to be released soon as 3.4.1.
>
> > Do you know when this modification will be in package for ubuntu?
>
> No idea. Either persuade them to apply the tiny fix from Bug 7050
> into their 3.4.0 package, or wait for the 3.4.1 release and hope
> that it tickles down to packages quickly. Another option is
> to run trunk code, as many of us do.
Ok thanks for all Mark ! Sorry again I wasted your time.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7158] Issue with wrong X-Spam-Date-of-Scan
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7158
geoffrey@acyba.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |geoffrey@acyba.com
--- Comment #1 from geoffrey@acyba.com ---
Created attachment 5288
--> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5288&action=edit
Patch to correct the time problem
time_to_rfc822_date
l:591
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7158] Issue with wrong X-Spam-Date-of-Scan
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7158
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail@pccc.com
--- Comment #2 from Kevin A. McGrail <km...@pccc.com> ---
Just throwing away a parameter seems a hack. I think we need to fix the calls
to the function.
--
You are receiving this mail because:
You are the assignee for the bug.