You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Dave Brosius (Created) (JIRA)" <ji...@apache.org> on 2012/02/29 03:45:59 UTC

[jira] [Created] (CASSANDRA-3976) [patch[ don't compare byte arrays with ==

[patch[ don't compare byte arrays with ==
-----------------------------------------

                 Key: CASSANDRA-3976
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3976
             Project: Cassandra
          Issue Type: Improvement
          Components: Hadoop
            Reporter: Dave Brosius
            Priority: Trivial
         Attachments: cmp_bytearrays_w_equals.diff

code compares byte arrays with ==, use Arrays.equals

patch against trunk

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3976) [patch[ don't compare byte arrays with ==

Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218865#comment-13218865 ] 

Jonathan Ellis commented on CASSANDRA-3976:
-------------------------------------------

Wouldn't just start/finish.length == 0 be simpler?
                
> [patch[ don't compare byte arrays with ==
> -----------------------------------------
>
>                 Key: CASSANDRA-3976
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3976
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Hadoop
>            Reporter: Dave Brosius
>            Priority: Trivial
>         Attachments: cmp_bytearrays_w_equals.diff
>
>
> code compares byte arrays with ==, use Arrays.equals
> patch against trunk

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-3976) [patch[ don't compare byte arrays with ==

Posted by "Dave Brosius (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Brosius updated CASSANDRA-3976:
------------------------------------

    Attachment: cmp_bytearrays_w_equals_2.diff

indeed! how silly of me. new patch
                
> [patch[ don't compare byte arrays with ==
> -----------------------------------------
>
>                 Key: CASSANDRA-3976
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3976
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Hadoop
>            Reporter: Dave Brosius
>            Priority: Trivial
>         Attachments: cmp_bytearrays_w_equals.diff, cmp_bytearrays_w_equals_2.diff
>
>
> code compares byte arrays with ==, use Arrays.equals
> patch against trunk

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-3976) [patch[ don't compare byte arrays with ==

Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-3976:
--------------------------------------

             Reviewer: jbellis
    Affects Version/s: 1.1.0
        Fix Version/s: 1.1.0
             Assignee: Dave Brosius
    
> [patch[ don't compare byte arrays with ==
> -----------------------------------------
>
>                 Key: CASSANDRA-3976
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3976
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Hadoop
>    Affects Versions: 1.1.0
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 1.1.0
>
>         Attachments: cmp_bytearrays_w_equals.diff, cmp_bytearrays_w_equals_2.diff
>
>
> code compares byte arrays with ==, use Arrays.equals
> patch against trunk

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-3976) [patch[ don't compare byte arrays with ==

Posted by "Dave Brosius (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Brosius updated CASSANDRA-3976:
------------------------------------

    Attachment: cmp_bytearrays_w_equals.diff
    
> [patch[ don't compare byte arrays with ==
> -----------------------------------------
>
>                 Key: CASSANDRA-3976
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3976
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Hadoop
>            Reporter: Dave Brosius
>            Priority: Trivial
>         Attachments: cmp_bytearrays_w_equals.diff
>
>
> code compares byte arrays with ==, use Arrays.equals
> patch against trunk

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira