[Impala-CR](cdh5-trunk) IMPALA-3604: Clean up SSE handling

["Jim Apple (Code Review)" <ge...@cloudera.org>]

Jim Apple has posted comments on this change.

Change subject: IMPALA-3604: Clean up SSE handling
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3227/2/be/src/util/sse-util.h
File be/src/util/sse-util.h:

> Greetings, Jim. 
I don't trust the compiler explorer to accurately represent the full state of the situation, but, in any case, adding 3-4 instructions to a one instruction function could make things a lot slower. Can you please find existing benchmarks (or write new ones) to make sure that it isn't making the code slower?


-- 
To view, visit http://gerrit.cloudera.org:8080/3227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id346187f3248922ec2a323548de4bdeaccd7a771
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Youwei Wang <yo...@intel.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Youwei Wang <yo...@intel.com>
Gerrit-HasComments: Yes