You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/09 08:05:17 UTC
[GitHub] [apisix-ingress-controller] fengxsong opened a new pull request, #1080: fix: fix tag for keyAuth field
fengxsong opened a new pull request, #1080:
URL: https://github.com/apache/apisix-ingress-controller/pull/1080
### Type of change:
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
### What this PR does / why we need it:
I'm currently doing some work to migrate kong's configuration to apisixroute, when marshaling `github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2beta3.ApisixRoute` object, the output of `keyAuth` field is `keyauth`.
So when I applied the generated manifests to apiserver, action failed because of CRD's Scheme verification.
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1080: fix: fix tag for keyAuth field
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1080:
URL: https://github.com/apache/apisix-ingress-controller/pull/1080#issuecomment-1150839870
```
test/e2e/suite-features/consumer.go
270: name: keyauth
274: assert.Nil(ginkgo.GinkgoT(), s.CreateResourceFromString(secret), "creating keyauth secret for ApisixConsumer")
275: assert.Nil(ginkgo.GinkgoT(), s.ApisixConsumerKeyAuthSecretCreated("keyvalue", "keyauth"), "creating keyAuth ApisixConsumer")
```
Although it doesn't matter, can you update all of the above together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1080: fix: fix tag for keyAuth field
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1080:
URL: https://github.com/apache/apisix-ingress-controller/pull/1080#issuecomment-1150897274
let's move forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1080: fix: fix tag for keyAuth field
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged PR #1080:
URL: https://github.com/apache/apisix-ingress-controller/pull/1080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org