You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Jark Wu (Jira)" <ji...@apache.org> on 2020/05/11 09:30:00 UTC

[jira] [Comment Edited] (FLINK-17606) Introduce DataGen connector in table

    [ https://issues.apache.org/jira/browse/FLINK-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104263#comment-17104263 ] 

Jark Wu edited comment on FLINK-17606 at 5/11/20, 9:29 AM:
-----------------------------------------------------------

I have some thoughts:
1) please update the options keys to the new style, e.g. {{connector}}, {{rows-per-second}}, {{total-records}}.
2) could you use {{fields.}} as prefix instead of {{schema.}}? Because it will conflict with the schema properties and may cause some unexpected problem.
3) the generator doesn't follow json style, could we merge {{generator}} and {{generator.start/max/min}} ? For example:

{{fields.id.generator='random(0, 100)'}}


was (Author: jark):
I have some thoughts:
1) please update the options keys to the new style, e.g. {{connector=datagen}}, {{rows-per-second}, {{total-records}}.
2) could you use {{fields.}} as prefix instead of {{schema.}}? Because it will conflict with the schema properties and may cause some unexpected problem.
3) the generator doesn't follow json style, could we merge {{generator}} and {{generator.start/max/min}} ? For example:

{{fields.id.generator='random(0, 100)'}}

> Introduce DataGen connector in table
> ------------------------------------
>
>                 Key: FLINK-17606
>                 URL: https://issues.apache.org/jira/browse/FLINK-17606
>             Project: Flink
>          Issue Type: Sub-task
>            Reporter: Jingsong Lee
>            Assignee: Jingsong Lee
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.11.0
>
>
> {code:java}
> CREATE TABLE user (
>     id BIGINT,
>     age INT,
>     description STRING
> ) WITH (
>     'connector.type' = 'datagen',
>     'connector.rows-per-second'='100',
>     'connector.total-records'='1000000',
>     'schema.id.generator' = 'sequence',
>     'schema.id.generator.start' = '1',
>     'schema.age.generator' = 'random',
>     'schema.age.generator.min' = '0',
>     'schema.age.generator.max' = '100',
>     'schema.description.generator' = 'random',
>     'schema.description.generator.length' = '100'
> )
> -- Default is random generator.
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)