You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/02/20 07:42:55 UTC

[GitHub] [commons-codec] arturobernalg commented on a change in pull request #107: Inline variable.

arturobernalg commented on a change in pull request #107:
URL: https://github.com/apache/commons-codec/pull/107#discussion_r810583677



##########
File path: src/main/java/org/apache/commons/codec/digest/UnixCrypt.java
##########
@@ -326,8 +326,7 @@ public static String crypt(final String original, final String salt) {
     }
 
     private static int byteToUnsigned(final byte b) {
-        final int value = b;
-        return value < 0 ? value + 256 : value;
+        return (int) b < 0 ? (int) b + 256 : (int) b;

Review comment:
       Changed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org