You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/11 03:55:00 UTC
[jira] [Commented] (BEAM-3170) support topicPartition in
BeamKafkaTable
[ https://issues.apache.org/jira/browse/BEAM-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248307#comment-16248307 ]
ASF GitHub Bot commented on BEAM-3170:
--------------------------------------
GitHub user XuMingmin opened a pull request:
https://github.com/apache/beam/pull/4115
[BEAM-3170] support topicPartition in BeamKafkaTable
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/XuMingmin/beam BEAM-3170
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/4115.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4115
----
commit 1c5d33abc7fffff8ddca0ec284bd47dbc76de559
Author: mingmxu <mi...@ebay.com>
Date: 2017-11-11T03:51:37Z
support topicPartition in BeamKafkaTable
----
> support topicPartition in BeamKafkaTable
> ----------------------------------------
>
> Key: BEAM-3170
> URL: https://issues.apache.org/jira/browse/BEAM-3170
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Xu Mingmin
> Assignee: Xu Mingmin
>
> In {{KafkaIO}} there're two options to set the source topics/partitions, and we only support the 1st one now:
> {code}
> 1 .withTopics(topics)
> 2. withTopicPartitions(topicPartitions)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)