[jira] [Comment Edited] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

["Manikumar Reddy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597558#comment-14597558 ] 

Manikumar Reddy edited comment on KAFKA-1901 at 6/23/15 12:10 PM:
------------------------------------------------------------------

Probably the easiest thing to do would be to generate a properties file (kafkaversion.props) with  version, git-hash info in it and put that in kafka jar as a resource. 

[~jbrosenberg@gmail.com] Do you this approach works for you? 


was (Author: omkreddy):
Probably the easiest thing to do would be to generate a properties file (kafkaversion.props) with  version, git-hash info in it and put that in kafka jar as a resource. 

[~jbrosenberg@gmail.com] Do you this approach work for you? 

> Move Kafka version to be generated in code by build (instead of in manifest)
> ----------------------------------------------------------------------------
>
>                 Key: KAFKA-1901
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1901
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8.2.0
>            Reporter: Jason Rosenberg
>
> With 0.8.2 (rc2), I've started seeing this warning in the logs of apps deployed to our staging (both server and client):
> {code}
> 2015-01-23 00:55:25,273  WARN [async-message-sender-0] common.AppInfo$ - Can't read Kafka version from MANIFEST.MF. Possible cause: java.lang.NullPointerException
> {code}
> The issues is that in our deployment, apps are deployed with single 'shaded' jars (e.g. using the maven shade plugin).  This means the MANIFEST.MF file won't have a kafka version.  Instead, suggest the kafka build generate the proper version in code, as part of the build.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)