You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by xi...@apache.org on 2026/04/15 11:31:35 UTC

(pinot) 17/25: allow enforceConsumptionInOrder to be rewritten at runtime (#18045)

This is an automated email from the ASF dual-hosted git repository.

xiangfu pushed a commit to branch release/1.5.0-STP-2.134.x
in repository https://gitbox.apache.org/repos/asf/pinot.git

commit a02bca26ddbb228d69c781920356ae55d1a3ce6d
Author: Kartik Khare <kh...@gmail.com>
AuthorDate: Wed Apr 1 09:48:54 2026 +0530

    allow enforceConsumptionInOrder to be rewritten at runtime (#18045)
    
    Co-authored-by: Kartik Khare <kh...@kartiks-macbook-pro-3.wyvern-sun.ts.net>
    (cherry picked from commit e23528c04a71598812d328d6cd3fd10c6f8435d9)
---
 .../data/manager/realtime/RealtimeTableDataManager.java     |  7 +++++--
 .../data/manager/realtime/RealtimeTableDataManagerTest.java | 13 +++++++++++++
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
index 3b606ebb949..d3849e49e1b 100644
--- a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
+++ b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
@@ -832,8 +832,11 @@ public class RealtimeTableDataManager extends BaseTableDataManager {
         k -> new ConsumerCoordinator(_enforceConsumptionInOrder, this));
   }
 
-  @VisibleForTesting
-  void setEnforceConsumptionInOrder(boolean enforceConsumptionInOrder) {
+  public boolean isEnforceConsumptionInOrderEnabled() {
+    return _enforceConsumptionInOrder;
+  }
+
+  public void setEnforceConsumptionInOrder(boolean enforceConsumptionInOrder) {
     _enforceConsumptionInOrder = enforceConsumptionInOrder;
   }
 
diff --git a/pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManagerTest.java b/pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManagerTest.java
index 1c78091d16f..f2e3955d147 100644
--- a/pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManagerTest.java
+++ b/pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManagerTest.java
@@ -126,4 +126,17 @@ public class RealtimeTableDataManagerTest {
             .equals(streamMetadataProvider1)), 5, 2000, "streamMetadataProvider returned from cache must be new.");
     Assert.assertTrue(fakeRealtimeTableDataManager._cacheEntryRemovalNotified);
   }
+
+  @Test
+  public void testEnforceConsumptionInOrderRuntimeOverride() {
+    RealtimeTableDataManager realtimeTableDataManager = new RealtimeTableDataManager(null);
+
+    Assert.assertFalse(realtimeTableDataManager.isEnforceConsumptionInOrderEnabled());
+
+    realtimeTableDataManager.setEnforceConsumptionInOrder(true);
+    Assert.assertTrue(realtimeTableDataManager.isEnforceConsumptionInOrderEnabled());
+
+    realtimeTableDataManager.setEnforceConsumptionInOrder(false);
+    Assert.assertFalse(realtimeTableDataManager.isEnforceConsumptionInOrderEnabled());
+  }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org