You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "andyhuangdev (via GitHub)" <gi...@apache.org> on 2026/10/14 05:11:36 UTC
[PR] HDDS-16961. Fix OM fetch-key secret key refresh [ozone]
andyhuangdev opened a new pull request, #11526:
URL: https://github.com/apache/ozone/pull/11526
## What changes were proposed in this pull request?
ozone admin om fetch-key reports success without fetching SCM's current secret key because DefaultSecretKeyClient inherits an empty default implementation of refetchSecretKey(). After SCM forces a key rotation, the command continues to print OM's cached key ID.
This patch forwards the refresh call to the signer client. OM also unwraps UncheckedIOException so SCM fetch failures are returned through the standard OM error response.
Regression tests verify that refreshing updates the cached key, fetch failures propagate, and the CLI prints SCM's current key ID after forced rotation.
## What is the link to the Apache JIRA
[HDDS-16961](https://issues.apache.org/jira/browse/HDDS-16961)
## How was this patch tested?
The regression tests were first run without the fix and failed as expected. With the fix:
- 40 framework secret key and token unit tests passed.
- 13 integration tests passed across TestBlockTokensCLI, TestOMAdminRpcAuthorization, and TestBlockTokens.
- Checkstyle and RAT checks passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16961. Fix OM fetch-key secret key refresh [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on PR #11526:
URL: https://github.com/apache/ozone/pull/11526#issuecomment-6181204532
Merged. Thanks @andyhuangdev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16961. Fix OM fetch-key secret key refresh [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang merged PR #11526:
URL: https://github.com/apache/ozone/pull/11526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org