You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/17 08:49:25 UTC
[GitHub] [apisix] fukiki opened a new pull request #2451: WIP:plugin(request-validation): use draft7 way to rewrite the JSON Schema
fukiki opened a new pull request #2451:
URL: https://github.com/apache/apisix/pull/2451
- fix bug #2432
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] fukiki commented on a change in pull request #2451: Plugin(request-validation): use draft7 way to rewrite the JSON Schema
Posted by GitBox <gi...@apache.org>.
fukiki commented on a change in pull request #2451:
URL: https://github.com/apache/apisix/pull/2451#discussion_r507405839
##########
File path: t/plugin/request-validation.t
##########
@@ -271,46 +231,6 @@ hello1 world
"type": "roundrobin"
},
"uri": "/opentracing"
- }]],
Review comment:
> @fukiki may I ask the reason to to remove these contents? Thanks.
In my test environment, the parameter string is larger than the remain space of the fixed buffer, which causes nginx to report an error. Therefore, the optional parameter was deleted.
The code in `t/plugin/request-validation.t` has been restored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] imjoey commented on a change in pull request #2451: Plugin(request-validation): use draft7 way to rewrite the JSON Schema
Posted by GitBox <gi...@apache.org>.
imjoey commented on a change in pull request #2451:
URL: https://github.com/apache/apisix/pull/2451#discussion_r507458347
##########
File path: t/plugin/request-validation.t
##########
@@ -271,46 +231,6 @@ hello1 world
"type": "roundrobin"
},
"uri": "/opentracing"
- }]],
Review comment:
@fukiki Thanks and good to see it's back. 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis merged pull request #2451: Plugin(request-validation): use draft7 way to rewrite the JSON Schema
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #2451:
URL: https://github.com/apache/apisix/pull/2451
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] imjoey commented on a change in pull request #2451: WIP:plugin(request-validation): use draft7 way to rewrite the JSON Schema
Posted by GitBox <gi...@apache.org>.
imjoey commented on a change in pull request #2451:
URL: https://github.com/apache/apisix/pull/2451#discussion_r506939050
##########
File path: t/plugin/request-validation.t
##########
@@ -271,46 +231,6 @@ hello1 world
"type": "roundrobin"
},
"uri": "/opentracing"
- }]],
Review comment:
@fukiki may I ask the reason to to remove these contents? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org