You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Marcus Sorensen <sh...@gmail.com> on 2013/04/01 22:29:58 UTC

Review Request: CLOUDSTACK-1846, CLOUDSTACK-1845 - KVM Storage, sometimes KVMHA will remount deleted NFS pools, causing failures when defining new storage pools.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10227/
-----------------------------------------------------------

Review request for cloudstack and Joe Brockmeier.


Description
-------

CLOUDSTACK-1846, CLOUDSTACK-1845 - KVM Storage, sometimes KVMHA will remount
    deleted NFS pools, causing failures when defining new storage pools. Sometimes
    a storage pool has never been used on a host, and getStoragePool fails when
    copying templates or in storage migration. deleteStoragePool(pool) often fails
    silently, leaving no pool defined in libvirt, but a mountpoint left behind.
    This patch handles some of these exceptions and brings forward any issues via
    logging.


This addresses bugs CLOUDSTACK-1845 and CLOUDSTACK-1846.


Diffs
-----

  plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java 131c37e 

Diff: https://reviews.apache.org/r/10227/diff/


Testing
-------

Deployed new 4.0 zone in devcloud-kvm, tested volume downloads, template creation, storage migration


Thanks,

Marcus Sorensen


Re: Review Request: CLOUDSTACK-1846, CLOUDSTACK-1845 - KVM Storage, sometimes KVMHA will remount deleted NFS pools, causing failures when defining new storage pools.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10227/#review18619
-----------------------------------------------------------


Commit 3541aa86e34605e5ac4a99df84c47e6f6e7c71ee in branch refs/heads/4.0 from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3541aa8 ]

CLOUDSTACK-1846, CLOUDSTACK-1845 - KVM Storage, sometimes KVMHA will remount
deleted NFS pools, causing failures when defining new storage pools. Sometimes
a storage pool has never been used on a host, and getStoragePool fails when
copying templates or in storage migration. deleteStoragePool(pool) often fails
silently, leaving no pool defined in libvirt, but a mountpoint left behind.
This patch handles some of these exceptions and brings forward any issues via
logging.

Signed-off-by: Chip Childers <ch...@gmail.com>


- ASF Subversion and Git Services


On April 1, 2013, 8:29 p.m., Marcus Sorensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10227/
> -----------------------------------------------------------
> 
> (Updated April 1, 2013, 8:29 p.m.)
> 
> 
> Review request for cloudstack and Joe Brockmeier.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1846, CLOUDSTACK-1845 - KVM Storage, sometimes KVMHA will remount
>     deleted NFS pools, causing failures when defining new storage pools. Sometimes
>     a storage pool has never been used on a host, and getStoragePool fails when
>     copying templates or in storage migration. deleteStoragePool(pool) often fails
>     silently, leaving no pool defined in libvirt, but a mountpoint left behind.
>     This patch handles some of these exceptions and brings forward any issues via
>     logging.
> 
> 
> This addresses bugs CLOUDSTACK-1845 and CLOUDSTACK-1846.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java 131c37e 
> 
> Diff: https://reviews.apache.org/r/10227/diff/
> 
> 
> Testing
> -------
> 
> Deployed new 4.0 zone in devcloud-kvm, tested volume downloads, template creation, storage migration
> 
> 
> Thanks,
> 
> Marcus Sorensen
> 
>


Re: Review Request: CLOUDSTACK-1846, CLOUDSTACK-1845 - KVM Storage, sometimes KVMHA will remount deleted NFS pools, causing failures when defining new storage pools.

Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10227/#review18620
-----------------------------------------------------------

Ship it!


Ship It!

- Chip Childers


On April 1, 2013, 8:29 p.m., Marcus Sorensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10227/
> -----------------------------------------------------------
> 
> (Updated April 1, 2013, 8:29 p.m.)
> 
> 
> Review request for cloudstack and Joe Brockmeier.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1846, CLOUDSTACK-1845 - KVM Storage, sometimes KVMHA will remount
>     deleted NFS pools, causing failures when defining new storage pools. Sometimes
>     a storage pool has never been used on a host, and getStoragePool fails when
>     copying templates or in storage migration. deleteStoragePool(pool) often fails
>     silently, leaving no pool defined in libvirt, but a mountpoint left behind.
>     This patch handles some of these exceptions and brings forward any issues via
>     logging.
> 
> 
> This addresses bugs CLOUDSTACK-1845 and CLOUDSTACK-1846.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java 131c37e 
> 
> Diff: https://reviews.apache.org/r/10227/diff/
> 
> 
> Testing
> -------
> 
> Deployed new 4.0 zone in devcloud-kvm, tested volume downloads, template creation, storage migration
> 
> 
> Thanks,
> 
> Marcus Sorensen
> 
>