You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/14 04:33:05 UTC

[GitHub] [arrow] emkornfield commented on a change in pull request #8648: ARROW-7906: [C++] [Python] Add ORC write support

emkornfield commented on a change in pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#discussion_r612929323



##########
File path: cpp/src/arrow/adapters/orc/adapter.cc
##########
@@ -44,20 +45,13 @@
 #include "arrow/util/macros.h"
 #include "arrow/util/range.h"
 #include "arrow/util/visibility.h"
-
 #include "orc/Exceptions.hh"
-#include "orc/OrcFile.hh"
+
+constexpr uint64_t kOrcWriterBatchSize = 100000;

Review comment:
       nit: power of 2 probably makes sense.  comment on how this was chosen (or if it was abitrary.  Also generally we avoid unsigned integers so if unsigned is required for API pursposes comment on it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org