[GitHub] [accumulo] dlmarion commented on a diff in pull request #3551: Add Metrics for CompactionJobPriority Queues

["dlmarion (via GitHub)" <gi...@apache.org>]

dlmarion commented on code in PR #3551:
URL: https://github.com/apache/accumulo/pull/3551#discussion_r1268521189


##########
core/src/main/java/org/apache/accumulo/core/metrics/MetricsProducer.java:
##########
@@ -597,6 +639,18 @@ public interface MetricsProducer {
   String METRICS_LOW_MEMORY = "accumulo.detected.low.memory";
   String METRICS_COMPACTOR_PREFIX = "accumulo.compactor.";
   String METRICS_COMPACTOR_MAJC_STUCK = METRICS_COMPACTOR_PREFIX + "majc.stuck";
+  String METRICS_COMPACTOR_JOB_PRIORITY_QUEUES = METRICS_COMPACTOR_PREFIX + "cjpq.count";

Review Comment:
   I wonder if we should use `queue` instead of `cjpq`.



##########
server/manager/src/main/java/org/apache/accumulo/manager/compaction/queue/CompactionJobQueues.java:
##########
@@ -41,6 +42,14 @@ public class CompactionJobQueues {
   private final ConcurrentHashMap<CompactionExecutorId,CompactionJobPriorityQueue> priorityQueues =
       new ConcurrentHashMap<>();
 
+  // Setting a stopgap global queue size variable.
+  // See GitHub Accumulo issue #3635
+  private int queueSize;

Review Comment:
   add `final` modifier?



##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -373,6 +373,11 @@ public enum Property {
       "1.10.0"),
   MANAGER_SPLIT_WORKER_THREADS("manager.split.inspection.threadpool.size", "8", PropertyType.COUNT,
       "The number of threads used to inspect tablets files to find split points.", "4.0.0"),
+
+  // This property is a stopgap. See GitHub Accumulo issue #3635.

Review Comment:
   I think we can remove this comment everywhere in this PR and the Experimental annotation. The property is addressing a TODO in CompactionJobQueues.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org