[GitHub] [hive] wecharyu commented on a diff in pull request #4076: HIVE-27097: Improve the retry strategy for MetaStore client and server

["wecharyu (via GitHub)" <gi...@apache.org>]

wecharyu commented on code in PR #4076:
URL: https://github.com/apache/hive/pull/4076#discussion_r1135936973


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java:
##########
@@ -264,17 +238,6 @@ public Object run() throws MetaException {
     return ret;
   }
 
-  private static boolean isRecoverableMetaException(MetaException e) {
-    String m = e.getMessage();
-    if (m == null) {
-      return false;
-    }
-    if (m.contains("java.sql.SQLIntegrityConstraintViolationException")) {
-      return false;
-    }
-    return IO_JDO_TRANSPORT_PROTOCOL_EXCEPTION_PATTERN.matcher(m).matches();

Review Comment:
   @saihemanth-cloudera nice concern! And thanks for your review.
   IMO we should seperate TTransportException from MetaException, because they are responsible for different things:
   
   - TTransportException means the exception in transport, like network issue.
   - MetaException means the meta data exception ,like meta data corrupted.
   
   BTW could you explain in which case TTransportException will be wrapped as MetaException?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org