You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/03/01 21:39:22 UTC

[GitHub] [activemq-artemis] brusdev opened a new pull request #3472: ARTEMIS-3147 Fix auto created addresses reload

brusdev opened a new pull request #3472:
URL: https://github.com/apache/activemq-artemis/pull/3472


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3472: ARTEMIS-3147 Fix auto created addresses reload

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3472:
URL: https://github.com/apache/activemq-artemis/pull/3472#issuecomment-789247722


   It does look good to me..
   
   However I saw a couple of failing tests on a recent run on this PR.
   
   I'm going to re-run this to make sure no tests are affected by this.
   
   
   they will probably be a test issue as I don't see how this could break anything.. but still I would like to check it before merging it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] asfgit closed pull request #3472: ARTEMIS-3147 Fix auto created addresses reload

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3472:
URL: https://github.com/apache/activemq-artemis/pull/3472


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic edited a comment on pull request #3472: ARTEMIS-3147 Fix auto created addresses reload

Posted by GitBox <gi...@apache.org>.
clebertsuconic edited a comment on pull request #3472:
URL: https://github.com/apache/activemq-artemis/pull/3472#issuecomment-789247722


   It does look good to me..
   
   However I saw a couple of failing tests on a recent run on this PR. (on a CI machine we have at our job)
   
   I'm going to re-run this to make sure no tests are affected by this.
   
   
   they will probably be a test issue as I don't see how this could break anything.. but still I would like to check it before merging it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] brusdev commented on pull request #3472: ARTEMIS-3147 Fix auto created addresses reload

Posted by GitBox <gi...@apache.org>.
brusdev commented on pull request #3472:
URL: https://github.com/apache/activemq-artemis/pull/3472#issuecomment-789747055


   @clebertsuconic I have executed the tests again but I can't find any failure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3472: ARTEMIS-3147 Fix auto created addresses reload

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3472:
URL: https://github.com/apache/activemq-artemis/pull/3472#issuecomment-789971795


   merging it


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3472: ARTEMIS-3147 Fix auto created addresses reload

Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3472:
URL: https://github.com/apache/activemq-artemis/pull/3472#issuecomment-788466550


   Lgtm +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org