[GitHub] [cassandra] dchenbecker commented on pull request #1940: [CASSANDRA-17950] Enable dtest-offheap in CircleCI

[GitBox <gi...@apache.org>]

dchenbecker commented on PR #1940:
URL: https://github.com/apache/cassandra/pull/1940#issuecomment-1288298291

   
   >     * I do not understand this sentence - "Because dtest-offheap in Jenkins is configured to skip resource intensive tests, the dtest-offheap suite is added to all three sets (LOW, MEDIUM, HIGH)." Is it just a mistake adding `,` instead of `.`? As LOW, MEDIUM and HIGH have nothing to do with whether we skip resource-intensive tests.
   
   That's a leftover from my initial misunderstanding of how things worked. Initially I thought that line was true because the offheap tests explicitly set `--skip-resource-intensive-tests`, but I'll remove that comment from the commit message
   
   > 
   >     * I am not sure I mentioned that even if the patches can still be applied, we need to recreate them as otherwise we get warnings like this every time on using the `generate.sh` script
   
   OK, I'll fix this. Off-topic, but patch gymnastics like this are something I hope we can eliminate with pipeline parameters. I'll write up a proposal this week (as an orthogonal concern, not blocking this PR).
   
   >     * Actually how were MIDRES and HIGHRES created? They use the same j8_par_executor as the other dtests but I see different resources in Midres - medium and 25, when j8_dtests gets large and 50?
   
   I edited config-2_1.yml to add the new test and then ran `generate.sh -a` per the README instructions. Did I miss a step?
   
   > 
   >     * In 4.0+ we will need also JDK11, once we have the details around JDK8 one that will be easy to add. Just adding here so we do not forget it.
   
   Yup, I'll make sure to include j11 in the 4.0+ branches. 
   > 
   >     * We will need also repeat jobs so we can fight the flakiness :-) Something like this : [97ebcb5](https://github.com/apache/cassandra/commit/97ebcb5fe6ae290da0a24228177df8e47aefbaba)
   
   That's the commit I'm PRing here, so did you mean a different commit?
   
   I feel a lot closer now than I did last week :)
   
   Cheers!
   
   Derek


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org