You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Eric Gillespie <ep...@google.com> on 2007/09/04 22:49:35 UTC
Re: svn commit: r26422 - trunk/subversion/include
malcolm@tigris.org writes:
> Author: malcolm
> Date: Sat Sep 1 16:19:42 2007
> New Revision: 26422
>
> Log:
> * subversion/include/svn_config.h
> (SVN_CONFIG_DEFAULT_GLOBAL_IGNORES): Remove two redundant patterns. (Note
> that, unlike many Unix shells, fnmatch will allow metacharacters to match
> leading periods).
Where is this documented? We should provide a pointer from here
to to the fnmatch documentation. apr_fnmatch.h doesn't seem to
explain it though. If it isn't documented anywhere, we should at
least document this much ourselves.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r26422 - trunk/subversion/include
Posted by David Glasser <gl...@davidglasser.net>.
On 9/5/07, Daniel Rall <dl...@apache.org> wrote:
> On Wed, 05 Sep 2007, Malcolm Rowe wrote:
>
> > On Tue, Sep 04, 2007 at 03:49:35PM -0700, Eric Gillespie wrote:
> > > > * subversion/include/svn_config.h
> > > > (SVN_CONFIG_DEFAULT_GLOBAL_IGNORES): Remove two redundant patterns. (Note
> > > > that, unlike many Unix shells, fnmatch will allow metacharacters to match
> > > > leading periods).
> > >
> > > Where is this documented? We should provide a pointer from here
> > > to to the fnmatch documentation. apr_fnmatch.h doesn't seem to
> > > explain it though. If it isn't documented anywhere, we should at
> > > least document this much ourselves.
> > >
> >
> > Yeah, it's pretty underdocumented. If we assume that apr_fnmatch() is
> > just an extension of the POSIX fnmatch() function (APR's documentation
> > doesn't say), then see e.g. here:
> >
> > http://www.opengroup.org/onlinepubs/000095399/functions/fnmatch.html
> >
> > "If FNM_PERIOD is set in flags, then a leading period ('.') in string
> > shall match a period in pattern [... some verbiage and references that
> > define a leading period and imply that it's not matched by other
> > metacharacters when this flag is set ...]. If FNM_PERIOD is not set,
> > then no special restrictions are placed on matching a period."
> >
> > We pass no flags, so we don't get this special behaviour. We could
> > alternatively revert my change and pass in APR_FNM_PERIOD if we think
> > that the current behaviour is a bug.
>
> It'd be nice if APR's header files documented the behavior...
apr_fnmatch is documented on trunk (I wrote the docs, so hopefully
they are clear) but apparently not in either release branch.
http://apr.apache.org/docs/apr/trunk/group__apr__fnmatch.html#gbe9c7d7efe6afc203a01befbc45bad96
--dave
--
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r26422 - trunk/subversion/include
Posted by David Glasser <gl...@davidglasser.net>.
On 9/5/07, Daniel Rall <dl...@apache.org> wrote:
> On Wed, 05 Sep 2007, Malcolm Rowe wrote:
>
> > On Tue, Sep 04, 2007 at 03:49:35PM -0700, Eric Gillespie wrote:
> > > > * subversion/include/svn_config.h
> > > > (SVN_CONFIG_DEFAULT_GLOBAL_IGNORES): Remove two redundant patterns. (Note
> > > > that, unlike many Unix shells, fnmatch will allow metacharacters to match
> > > > leading periods).
> > >
> > > Where is this documented? We should provide a pointer from here
> > > to to the fnmatch documentation. apr_fnmatch.h doesn't seem to
> > > explain it though. If it isn't documented anywhere, we should at
> > > least document this much ourselves.
> > >
> >
> > Yeah, it's pretty underdocumented. If we assume that apr_fnmatch() is
> > just an extension of the POSIX fnmatch() function (APR's documentation
> > doesn't say), then see e.g. here:
> >
> > http://www.opengroup.org/onlinepubs/000095399/functions/fnmatch.html
> >
> > "If FNM_PERIOD is set in flags, then a leading period ('.') in string
> > shall match a period in pattern [... some verbiage and references that
> > define a leading period and imply that it's not matched by other
> > metacharacters when this flag is set ...]. If FNM_PERIOD is not set,
> > then no special restrictions are placed on matching a period."
> >
> > We pass no flags, so we don't get this special behaviour. We could
> > alternatively revert my change and pass in APR_FNM_PERIOD if we think
> > that the current behaviour is a bug.
>
> It'd be nice if APR's header files documented the behavior...
apr_fnmatch is documented on trunk (I wrote the docs, so hopefully
they are clear) but apparently not in either release branch.
http://apr.apache.org/docs/apr/trunk/group__apr__fnmatch.html#gbe9c7d7efe6afc203a01befbc45bad96
--dave
--
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
Re: svn commit: r26422 - trunk/subversion/include
Posted by Daniel Rall <dl...@apache.org>.
On Wed, 05 Sep 2007, Malcolm Rowe wrote:
> On Tue, Sep 04, 2007 at 03:49:35PM -0700, Eric Gillespie wrote:
> > > * subversion/include/svn_config.h
> > > (SVN_CONFIG_DEFAULT_GLOBAL_IGNORES): Remove two redundant patterns. (Note
> > > that, unlike many Unix shells, fnmatch will allow metacharacters to match
> > > leading periods).
> >
> > Where is this documented? We should provide a pointer from here
> > to to the fnmatch documentation. apr_fnmatch.h doesn't seem to
> > explain it though. If it isn't documented anywhere, we should at
> > least document this much ourselves.
> >
>
> Yeah, it's pretty underdocumented. If we assume that apr_fnmatch() is
> just an extension of the POSIX fnmatch() function (APR's documentation
> doesn't say), then see e.g. here:
>
> http://www.opengroup.org/onlinepubs/000095399/functions/fnmatch.html
>
> "If FNM_PERIOD is set in flags, then a leading period ('.') in string
> shall match a period in pattern [... some verbiage and references that
> define a leading period and imply that it's not matched by other
> metacharacters when this flag is set ...]. If FNM_PERIOD is not set,
> then no special restrictions are placed on matching a period."
>
> We pass no flags, so we don't get this special behaviour. We could
> alternatively revert my change and pass in APR_FNM_PERIOD if we think
> that the current behaviour is a bug.
It'd be nice if APR's header files documented the behavior...
Re: svn commit: r26422 - trunk/subversion/include
Posted by Daniel Rall <dl...@apache.org>.
On Wed, 05 Sep 2007, Malcolm Rowe wrote:
> On Tue, Sep 04, 2007 at 03:49:35PM -0700, Eric Gillespie wrote:
> > > * subversion/include/svn_config.h
> > > (SVN_CONFIG_DEFAULT_GLOBAL_IGNORES): Remove two redundant patterns. (Note
> > > that, unlike many Unix shells, fnmatch will allow metacharacters to match
> > > leading periods).
> >
> > Where is this documented? We should provide a pointer from here
> > to to the fnmatch documentation. apr_fnmatch.h doesn't seem to
> > explain it though. If it isn't documented anywhere, we should at
> > least document this much ourselves.
> >
>
> Yeah, it's pretty underdocumented. If we assume that apr_fnmatch() is
> just an extension of the POSIX fnmatch() function (APR's documentation
> doesn't say), then see e.g. here:
>
> http://www.opengroup.org/onlinepubs/000095399/functions/fnmatch.html
>
> "If FNM_PERIOD is set in flags, then a leading period ('.') in string
> shall match a period in pattern [... some verbiage and references that
> define a leading period and imply that it's not matched by other
> metacharacters when this flag is set ...]. If FNM_PERIOD is not set,
> then no special restrictions are placed on matching a period."
>
> We pass no flags, so we don't get this special behaviour. We could
> alternatively revert my change and pass in APR_FNM_PERIOD if we think
> that the current behaviour is a bug.
It'd be nice if APR's header files documented the behavior...
Re: svn commit: r26422 - trunk/subversion/include
Posted by Malcolm Rowe <ma...@farside.org.uk>.
On Tue, Sep 04, 2007 at 03:49:35PM -0700, Eric Gillespie wrote:
> > * subversion/include/svn_config.h
> > (SVN_CONFIG_DEFAULT_GLOBAL_IGNORES): Remove two redundant patterns. (Note
> > that, unlike many Unix shells, fnmatch will allow metacharacters to match
> > leading periods).
>
> Where is this documented? We should provide a pointer from here
> to to the fnmatch documentation. apr_fnmatch.h doesn't seem to
> explain it though. If it isn't documented anywhere, we should at
> least document this much ourselves.
>
Yeah, it's pretty underdocumented. If we assume that apr_fnmatch() is
just an extension of the POSIX fnmatch() function (APR's documentation
doesn't say), then see e.g. here:
http://www.opengroup.org/onlinepubs/000095399/functions/fnmatch.html
"If FNM_PERIOD is set in flags, then a leading period ('.') in string
shall match a period in pattern [... some verbiage and references that
define a leading period and imply that it's not matched by other
metacharacters when this flag is set ...]. If FNM_PERIOD is not set,
then no special restrictions are placed on matching a period."
We pass no flags, so we don't get this special behaviour. We could
alternatively revert my change and pass in APR_FNM_PERIOD if we think
that the current behaviour is a bug.
Regards,
Malcolm