You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by yu...@apache.org on 2017/08/29 12:30:50 UTC

[22/28] incubator-rocketmq git commit: Minor Polish

Minor Polish


Project: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq/commit/4c5e58b4
Tree: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq/tree/4c5e58b4
Diff: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq/diff/4c5e58b4

Branch: refs/heads/master
Commit: 4c5e58b46acaf4541fbd741b97593618f027be2d
Parents: 76464ba
Author: vongosling <vo...@apache.org>
Authored: Mon Aug 28 18:16:39 2017 +0800
Committer: vongosling <vo...@apache.org>
Committed: Mon Aug 28 18:16:39 2017 +0800

----------------------------------------------------------------------
 .../main/java/org/apache/rocketmq/client/log/ClientLogger.java    | 1 -
 .../java/org/apache/rocketmq/client/log/ClientLoggerTest.java     | 3 ++-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-rocketmq/blob/4c5e58b4/client/src/main/java/org/apache/rocketmq/client/log/ClientLogger.java
----------------------------------------------------------------------
diff --git a/client/src/main/java/org/apache/rocketmq/client/log/ClientLogger.java b/client/src/main/java/org/apache/rocketmq/client/log/ClientLogger.java
index e84a069..c3df9a6 100644
--- a/client/src/main/java/org/apache/rocketmq/client/log/ClientLogger.java
+++ b/client/src/main/java/org/apache/rocketmq/client/log/ClientLogger.java
@@ -98,7 +98,6 @@ public class ClientLogger {
                         initialize.invoke(joranConfigurator, "log4j2", logConfigFilePath);
                     }
                 }
-                //logClass = classType;
             } catch (Exception e) {
                 System.err.println(e);
             }

http://git-wip-us.apache.org/repos/asf/incubator-rocketmq/blob/4c5e58b4/client/src/test/java/org/apache/rocketmq/client/log/ClientLoggerTest.java
----------------------------------------------------------------------
diff --git a/client/src/test/java/org/apache/rocketmq/client/log/ClientLoggerTest.java b/client/src/test/java/org/apache/rocketmq/client/log/ClientLoggerTest.java
index 0559e0d..d3f3be7 100644
--- a/client/src/test/java/org/apache/rocketmq/client/log/ClientLoggerTest.java
+++ b/client/src/test/java/org/apache/rocketmq/client/log/ClientLoggerTest.java
@@ -43,9 +43,10 @@ public class ClientLoggerTest {
 
     // FIXME: Workaround for concrete implementation for slf4j, is there any better solution for all slf4j implementations in one class ? 2017/8/1
     @Test
-    public void testLog4j() throws Exception {
+    public void testLog4j2() throws Exception {
         Logger logger = ClientLogger.getLog();
 
+        System.out.println(logger);
         assertEquals("org.apache.logging.slf4j.Log4jLogger", logger.getClass().getName());
     }
 }