You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Anu Engineer (JIRA)" <ji...@apache.org> on 2019/01/04 18:45:00 UTC

[jira] [Commented] (HDDS-915) Submit client request to OM Ratis server

    [ https://issues.apache.org/jira/browse/HDDS-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734462#comment-16734462 ] 

Anu Engineer commented on HDDS-915:
-----------------------------------

[~hanishakoneru] Thanks for this patch. You have made amazing progress on the HA work for Ozone Manager. I am +1 on this patch. Some very minor comments

 

1. OmUtils.java#isReadOnly - Do you think it is a good idea to log a Error message if we hit the default case? or add some kind of test that will send all the known enums. I want to avoid the situation where some adds a new operation and we never realize it. Case in point: the GetS3Secret getting added to Ozone Manager - HDDS-938.

2. Nit: OzoneManager.java#validRequest -- rename?--> isValidRequest -- we are not using this function. So feel free to ignore this comment.

3. Not sure I understand this change, in OzoneManagerProtocol.proto, we make cmdType from required to optional. Is there a reason to do it? or just generally following good practices of protobuf. Optional is preferred over required in many cases.

 

 

> Submit client request to OM Ratis server
> ----------------------------------------
>
>                 Key: HDDS-915
>                 URL: https://issues.apache.org/jira/browse/HDDS-915
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Hanisha Koneru
>            Assignee: Hanisha Koneru
>            Priority: Major
>         Attachments: HDDS-915.001.patch, HDDS-915.002.patch
>
>
> OM ratis client should submit incoming client request to the ratis server. OM should distinguish read requests and write requests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org