You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/11 20:48:04 UTC

[jira] [Commented] (ORC-184) [C++] Refactor ColumnStatistics classes for writer

    [ https://issues.apache.org/jira/browse/ORC-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007156#comment-16007156 ] 

ASF GitHub Bot commented on ORC-184:
------------------------------------

GitHub user wgtmac opened a pull request:

    https://github.com/apache/orc/pull/120

    ORC-184: Refactor ColumnStatistics classes for writer

    1. Added several functions to ColumnStatistic class inclduing hasNull, merge, reset, toProtoBuf, etc.
    2. Added functions to scale up/down for Int128 and comparision function for Decimal types.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wgtmac/orc ORC-184

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/orc/pull/120.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #120
    
----
commit 1a9bc74a4744fc5316afff487f35f05ca7ac9048
Author: Gang Wu <ga...@alibaba-inc.com>
Date:   2017-05-11T20:44:38Z

    ORC-184: Refactor ColumnStatistics classes for writer
    
    1. Added several functions to ColumnStatistic class inclduing hasNull, merge, reset, toProtoBuf, etc.
    2. Added functions to scale up/down for Int128 and comparision function for Decimal types.

----


> [C++] Refactor ColumnStatistics classes for writer
> --------------------------------------------------
>
>                 Key: ORC-184
>                 URL: https://issues.apache.org/jira/browse/ORC-184
>             Project: ORC
>          Issue Type: Sub-task
>          Components: C++
>            Reporter: Gang Wu
>            Assignee: Gang Wu
>
> 1. Add setter functions to ColumnStatistics.
> 2. Refactor ColumnStatistics to reduce duplicate code.
> 3. Add more functions in Int128 and Decimal classes for DecimalColumnStatistics.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)