You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/09 23:05:44 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #33949: [SPARK-36334][K8S][FOLLOWUP] Allow equal resource version to update snapshot
dongjoon-hyun opened a new pull request #33949:
URL: https://github.com/apache/spark/pull/33949
### What changes were proposed in this pull request?
This PR aims to allow snapshot updates when the resource version is equal to the previous version.
### Why are the changes needed?
This will prevent the chance of timing issue when the driver may not register executors yet when the last pod update events.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33949: [SPARK-36334][K8S][FOLLOWUP] Allow equal resource version to update snapshot
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33949:
URL: https://github.com/apache/spark/pull/33949#issuecomment-916518579
Jenkins passed and most GitHub Action passed. Currently, Java11/Linter/doc generation jobs are running but they are irrelevant to this K8s patch.
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33949: [SPARK-36334][K8S][FOLLOWUP] Allow equal resource version to update snapshot
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33949:
URL: https://github.com/apache/spark/pull/33949#issuecomment-916515864
**[Test build #143131 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143131/testReport)** for PR 33949 at commit [`70d2d7c`](https://github.com/apache/spark/commit/70d2d7cb40517572627577671814e600ed88faec).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33949: [SPARK-36334][K8S][FOLLOWUP] Allow equal resource version to update snapshot
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33949:
URL: https://github.com/apache/spark/pull/33949#issuecomment-916515986
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143131/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #33949: [SPARK-36334][K8S][FOLLOWUP] Allow equal resource version to update snapshot
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #33949:
URL: https://github.com/apache/spark/pull/33949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33949: [SPARK-36334][K8S][FOLLOWUP] Allow equal resource version to update snapshot
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33949:
URL: https://github.com/apache/spark/pull/33949#issuecomment-916511313
**[Test build #143131 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143131/testReport)** for PR 33949 at commit [`70d2d7c`](https://github.com/apache/spark/commit/70d2d7cb40517572627577671814e600ed88faec).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33949: [SPARK-36334][K8S][FOLLOWUP] Allow equal resource version to update snapshot
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #33949:
URL: https://github.com/apache/spark/pull/33949#discussion_r705784682
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
##########
@@ -67,9 +67,9 @@ private[spark] class ExecutorPodsPollingSnapshotSource(
if (conf.get(KUBERNETES_EXECUTOR_API_POLLING_WITH_RESOURCE_VERSION)) {
val list = pods.list(new ListOptionsBuilder().withResourceVersion("0").build())
val newResourceVersion = UnsignedLong.valueOf(list.getMetadata.getResourceVersion())
- // Replace only when we receive a monotonically increased resourceVersion
+ // Replace only when we receive a monotonically increased or equal resourceVersion
// because some K8s API servers may return old(smaller) cached versions in case of HA setup.
- if (resourceVersion == null || newResourceVersion.compareTo(resourceVersion) > 0) {
+ if (resourceVersion == null || newResourceVersion.compareTo(resourceVersion) >= 0) {
Review comment:
The resource will be the same. We simply invoke `snapshotsStore.replaceSnapshot(list.getItems.asScala.toSeq)` again to make it sure that the driver works in the same way of Spark 3.2 and olders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33949: [SPARK-36334][K8S][FOLLOWUP] Allow equal resource version to update snapshot
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33949:
URL: https://github.com/apache/spark/pull/33949#issuecomment-916515986
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143131/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33949: [SPARK-36334][K8S][FOLLOWUP] Allow equal resource version to update snapshot
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33949:
URL: https://github.com/apache/spark/pull/33949#issuecomment-916511313
**[Test build #143131 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143131/testReport)** for PR 33949 at commit [`70d2d7c`](https://github.com/apache/spark/commit/70d2d7cb40517572627577671814e600ed88faec).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33949: [SPARK-36334][K8S][FOLLOWUP] Allow equal resource version to update snapshot
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33949:
URL: https://github.com/apache/spark/pull/33949#issuecomment-916536019
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47635/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #33949: [SPARK-36334][K8S][FOLLOWUP] Allow equal resource version to update snapshot
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #33949:
URL: https://github.com/apache/spark/pull/33949#discussion_r705787617
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
##########
@@ -67,9 +67,9 @@ private[spark] class ExecutorPodsPollingSnapshotSource(
if (conf.get(KUBERNETES_EXECUTOR_API_POLLING_WITH_RESOURCE_VERSION)) {
val list = pods.list(new ListOptionsBuilder().withResourceVersion("0").build())
val newResourceVersion = UnsignedLong.valueOf(list.getMetadata.getResourceVersion())
- // Replace only when we receive a monotonically increased resourceVersion
+ // Replace only when we receive a monotonically increased or equal resourceVersion
// because some K8s API servers may return old(smaller) cached versions in case of HA setup.
- if (resourceVersion == null || newResourceVersion.compareTo(resourceVersion) > 0) {
+ if (resourceVersion == null || newResourceVersion.compareTo(resourceVersion) >= 0) {
Review comment:
nvm, got the idea. yea, it looks reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33949: [SPARK-36334][K8S][FOLLOWUP] Allow equal resource version to update snapshot
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33949:
URL: https://github.com/apache/spark/pull/33949#issuecomment-916499841
cc @shrutig , @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33949: [SPARK-36334][K8S][FOLLOWUP] Allow equal resource version to update snapshot
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33949:
URL: https://github.com/apache/spark/pull/33949#issuecomment-916536019
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47635/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33949: [SPARK-36334][K8S][FOLLOWUP] Allow equal resource version to update snapshot
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #33949:
URL: https://github.com/apache/spark/pull/33949#discussion_r705784682
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
##########
@@ -67,9 +67,9 @@ private[spark] class ExecutorPodsPollingSnapshotSource(
if (conf.get(KUBERNETES_EXECUTOR_API_POLLING_WITH_RESOURCE_VERSION)) {
val list = pods.list(new ListOptionsBuilder().withResourceVersion("0").build())
val newResourceVersion = UnsignedLong.valueOf(list.getMetadata.getResourceVersion())
- // Replace only when we receive a monotonically increased resourceVersion
+ // Replace only when we receive a monotonically increased or equal resourceVersion
// because some K8s API servers may return old(smaller) cached versions in case of HA setup.
- if (resourceVersion == null || newResourceVersion.compareTo(resourceVersion) > 0) {
+ if (resourceVersion == null || newResourceVersion.compareTo(resourceVersion) >= 0) {
Review comment:
The resource itself will be the same. We simply invoke `snapshotsStore.replaceSnapshot(list.getItems.asScala.toSeq)` again to make it sure that the driver works in the same way of Spark 3.2 and olders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33949: [SPARK-36334][K8S][FOLLOWUP] Allow equal resource version to update snapshot
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33949:
URL: https://github.com/apache/spark/pull/33949#issuecomment-916527331
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47635/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #33949: [SPARK-36334][K8S][FOLLOWUP] Allow equal resource version to update snapshot
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #33949:
URL: https://github.com/apache/spark/pull/33949#discussion_r705784071
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
##########
@@ -67,9 +67,9 @@ private[spark] class ExecutorPodsPollingSnapshotSource(
if (conf.get(KUBERNETES_EXECUTOR_API_POLLING_WITH_RESOURCE_VERSION)) {
val list = pods.list(new ListOptionsBuilder().withResourceVersion("0").build())
val newResourceVersion = UnsignedLong.valueOf(list.getMetadata.getResourceVersion())
- // Replace only when we receive a monotonically increased resourceVersion
+ // Replace only when we receive a monotonically increased or equal resourceVersion
// because some K8s API servers may return old(smaller) cached versions in case of HA setup.
- if (resourceVersion == null || newResourceVersion.compareTo(resourceVersion) > 0) {
+ if (resourceVersion == null || newResourceVersion.compareTo(resourceVersion) >= 0) {
Review comment:
one question, the resource with equal version will be different?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33949: [SPARK-36334][K8S][FOLLOWUP] Allow equal resource version to update snapshot
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33949:
URL: https://github.com/apache/spark/pull/33949#issuecomment-916531698
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47635/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org