[GitHub] [flink] RocMarshal commented on a change in pull request #18386: [FLINK-25684][table] Support enhanced `show databases` syntax

[GitBox <gi...@apache.org>]

RocMarshal commented on a change in pull request #18386:
URL: https://github.com/apache/flink/pull/18386#discussion_r823349610



##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java
##########
@@ -505,10 +511,10 @@ void createTemporarySystemFunction(
      * (implicitly or explicitly) identified by a catalog and database.
      *
      * @param path The path under which the function will be registered. See also the {@link
-     *     TableEnvironment} class description for the format of the path.
+     *         TableEnvironment} class description for the format of the path.
      * @param functionClass The function class containing the implementation.
      * @param ignoreIfExists If a function exists under the given path and this flag is set, no
-     *     operation is executed. An exception is thrown otherwise.
+     *         operation is executed. An exception is thrown otherwise.

Review comment:
       a little confusion : The change was caused by `mvn spotless:apply` command ?

##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala
##########
@@ -656,13 +656,48 @@ class TableEnvironmentTest {
   def testExecuteSqlWithShowDatabases(): Unit = {
     val tableResult1 = tableEnv.executeSql("CREATE DATABASE db1 COMMENT 'db1_comment'")
     assertEquals(ResultKind.SUCCESS, tableResult1.getResultKind)
-    val tableResult2 = tableEnv.executeSql("SHOW DATABASES")
+    val tableResult2 = tableEnv.executeSql("CREATE DATABASE db2 COMMENT 'db2_comment'")
+    assertEquals(ResultKind.SUCCESS, tableResult2.getResultKind)

Review comment:
       It's recommended  to use `assertThat` from assertj pacakge. If you think so, please  keep consistent in the rest of the related changed lines.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org