You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by ustcweizhou <gi...@git.apache.org> on 2017/02/16 13:09:36 UTC

[GitHub] cloudstack pull request #1946: CLOUDSTACK-9788: Fix exception listNetworks w...

GitHub user ustcweizhou opened a pull request:

    https://github.com/apache/cloudstack/pull/1946

    CLOUDSTACK-9788: Fix exception listNetworks with pagesize=0

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ustcweizhou/cloudstack pagesizeIs0

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1946.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1946
    
----
commit c883e294d36f64d09bed2f7e22086ab413f28d33
Author: Wei Zhou <w....@tech.leaseweb.com>
Date:   2017-02-16T11:01:44Z

    CLOUDSTACK-9788: Fix exception listNetworks with pagesize=0

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...

Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1946
  
    @blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...

Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1946
  
    @blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1946
  
    LGTM. @karuturi let's merge this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1946
  
    @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...

Posted by kiwiflyer <gi...@git.apache.org>.
Github user kiwiflyer commented on the issue:

    https://github.com/apache/cloudstack/pull/1946
  
    tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1946: CLOUDSTACK-9788: Fix exception listNetworks w...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/1946


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1946
  
    @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1946
  
    @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1946
  
    LGTM.
    @karuturi this is ready for merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1946
  
    Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-497


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1946
  
    This might affect other/all APIs therefore would require regression testing, but LGTM (did not test this).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...

Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1946
  
    Trillian build failed:
    16:43:38 FAILED - RETRYING: TASK: Wait for default template to be ready before returning (1 retries left).
    will try again.. 
    @blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1946
  
    <b>Trillian test result (tid-847)</b>
    Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
    Total time taken: 27629 seconds
    Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1946-t847-kvm-centos7.zip
    Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
    Test completed. 47 look ok, 1 have error(s)
    
    
    Test | Result | Time (s) | Test File
    --- | --- | --- | ---
    test_04_rvpc_privategw_static_routes | `Failure` | 351.29 | test_privategw_acl.py
    test_01_vpc_site2site_vpn | Success | 161.52 | test_vpc_vpn.py
    test_01_vpc_remote_access_vpn | Success | 66.11 | test_vpc_vpn.py
    test_01_redundant_vpc_site2site_vpn | Success | 261.82 | test_vpc_vpn.py
    test_02_VPC_default_routes | Success | 279.97 | test_vpc_router_nics.py
    test_01_VPC_nics_after_destroy | Success | 537.78 | test_vpc_router_nics.py
    test_05_rvpc_multi_tiers | Success | 513.75 | test_vpc_redundant.py
    test_04_rvpc_network_garbage_collector_nics | Success | 1418.87 | test_vpc_redundant.py
    test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 568.37 | test_vpc_redundant.py
    test_02_redundant_VPC_default_routes | Success | 759.18 | test_vpc_redundant.py
    test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1302.38 | test_vpc_redundant.py
    test_09_delete_detached_volume | Success | 151.41 | test_volumes.py
    test_08_resize_volume | Success | 156.31 | test_volumes.py
    test_07_resize_fail | Success | 161.42 | test_volumes.py
    test_06_download_detached_volume | Success | 156.60 | test_volumes.py
    test_05_detach_volume | Success | 155.75 | test_volumes.py
    test_04_delete_attached_volume | Success | 151.21 | test_volumes.py
    test_03_download_attached_volume | Success | 156.47 | test_volumes.py
    test_02_attach_volume | Success | 95.73 | test_volumes.py
    test_01_create_volume | Success | 711.63 | test_volumes.py
    test_deploy_vm_multiple | Success | 252.62 | test_vm_life_cycle.py
    test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
    test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
    test_10_attachAndDetach_iso | Success | 26.63 | test_vm_life_cycle.py
    test_09_expunge_vm | Success | 125.18 | test_vm_life_cycle.py
    test_08_migrate_vm | Success | 55.94 | test_vm_life_cycle.py
    test_07_restore_vm | Success | 0.12 | test_vm_life_cycle.py
    test_06_destroy_vm | Success | 125.78 | test_vm_life_cycle.py
    test_03_reboot_vm | Success | 125.86 | test_vm_life_cycle.py
    test_02_start_vm | Success | 10.18 | test_vm_life_cycle.py
    test_01_stop_vm | Success | 40.33 | test_vm_life_cycle.py
    test_CreateTemplateWithDuplicateName | Success | 65.69 | test_templates.py
    test_08_list_system_templates | Success | 0.03 | test_templates.py
    test_07_list_public_templates | Success | 0.04 | test_templates.py
    test_05_template_permissions | Success | 0.05 | test_templates.py
    test_04_extract_template | Success | 5.16 | test_templates.py
    test_03_delete_template | Success | 5.11 | test_templates.py
    test_02_edit_template | Success | 90.13 | test_templates.py
    test_01_create_template | Success | 35.37 | test_templates.py
    test_10_destroy_cpvm | Success | 191.82 | test_ssvm.py
    test_09_destroy_ssvm | Success | 163.95 | test_ssvm.py
    test_08_reboot_cpvm | Success | 131.58 | test_ssvm.py
    test_07_reboot_ssvm | Success | 134.41 | test_ssvm.py
    test_06_stop_cpvm | Success | 137.36 | test_ssvm.py
    test_05_stop_ssvm | Success | 133.62 | test_ssvm.py
    test_04_cpvm_internals | Success | 1.15 | test_ssvm.py
    test_03_ssvm_internals | Success | 3.26 | test_ssvm.py
    test_02_list_cpvm_vm | Success | 0.14 | test_ssvm.py
    test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
    test_01_snapshot_root_disk | Success | 11.23 | test_snapshots.py
    test_04_change_offering_small | Success | 242.59 | test_service_offerings.py
    test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
    test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py
    test_01_create_service_offering | Success | 0.10 | test_service_offerings.py
    test_02_sys_template_ready | Success | 0.12 | test_secondary_storage.py
    test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py
    test_09_reboot_router | Success | 35.70 | test_routers.py
    test_08_start_router | Success | 30.29 | test_routers.py
    test_07_stop_router | Success | 10.16 | test_routers.py
    test_06_router_advanced | Success | 0.05 | test_routers.py
    test_05_router_basic | Success | 0.04 | test_routers.py
    test_04_restart_network_wo_cleanup | Success | 5.71 | test_routers.py
    test_03_restart_network_cleanup | Success | 55.50 | test_routers.py
    test_02_router_internal_adv | Success | 1.04 | test_routers.py
    test_01_router_internal_basic | Success | 0.62 | test_routers.py
    test_router_dns_guestipquery | Success | 76.84 | test_router_dns.py
    test_router_dns_externalipquery | Success | 0.05 | test_router_dns.py
    test_router_dhcphosts | Success | 277.12 | test_router_dhcphosts.py
    test_router_dhcp_opts | Success | 21.77 | test_router_dhcphosts.py
    test_01_updatevolumedetail | Success | 0.07 | test_resource_detail.py
    test_01_reset_vm_on_reboot | Success | 130.89 | test_reset_vm_on_reboot.py
    test_createRegion | Success | 0.04 | test_regions.py
    test_create_pvlan_network | Success | 5.21 | test_pvlan.py
    test_dedicatePublicIpRange | Success | 0.42 | test_public_ip_range.py
    test_03_vpc_privategw_restart_vpc_cleanup | Success | 484.71 | test_privategw_acl.py
    test_02_vpc_privategw_static_routes | Success | 385.14 | test_privategw_acl.py
    test_01_vpc_privategw_acl | Success | 92.11 | test_privategw_acl.py
    test_01_primary_storage_nfs | Success | 35.79 | test_primary_storage.py
    test_createPortablePublicIPRange | Success | 15.18 | test_portable_publicip.py
    test_createPortablePublicIPAcquire | Success | 15.42 | test_portable_publicip.py
    test_isolate_network_password_server | Success | 89.24 | test_password_server.py
    test_UpdateStorageOverProvisioningFactor | Success | 0.12 | test_over_provisioning.py
    test_oobm_zchange_password | Success | 30.70 | test_outofbandmanagement.py
    test_oobm_multiple_mgmt_server_ownership | Success | 16.62 | test_outofbandmanagement.py
    test_oobm_issue_power_status | Success | 10.22 | test_outofbandmanagement.py
    test_oobm_issue_power_soft | Success | 15.35 | test_outofbandmanagement.py
    test_oobm_issue_power_reset | Success | 15.47 | test_outofbandmanagement.py
    test_oobm_issue_power_on | Success | 15.29 | test_outofbandmanagement.py
    test_oobm_issue_power_off | Success | 15.31 | test_outofbandmanagement.py
    test_oobm_issue_power_cycle | Success | 15.36 | test_outofbandmanagement.py
    test_oobm_enabledisable_across_clusterzones | Success | 82.83 | test_outofbandmanagement.py
    test_oobm_enable_feature_valid | Success | 5.15 | test_outofbandmanagement.py
    test_oobm_enable_feature_invalid | Success | 0.09 | test_outofbandmanagement.py
    test_oobm_disable_feature_valid | Success | 5.17 | test_outofbandmanagement.py
    test_oobm_disable_feature_invalid | Success | 0.17 | test_outofbandmanagement.py
    test_oobm_configure_invalid_driver | Success | 0.10 | test_outofbandmanagement.py
    test_oobm_configure_default_driver | Success | 0.07 | test_outofbandmanagement.py
    test_oobm_background_powerstate_sync | Success | 29.42 | test_outofbandmanagement.py
    test_extendPhysicalNetworkVlan | Success | 15.33 | test_non_contigiousvlan.py
    test_01_nic | Success | 449.09 | test_nic.py
    test_releaseIP | Success | 252.84 | test_network.py
    test_reboot_router | Success | 393.48 | test_network.py
    test_public_ip_user_account | Success | 10.24 | test_network.py
    test_public_ip_admin_account | Success | 40.25 | test_network.py
    test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 66.93 | test_network.py
    test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.61 | test_network.py
    test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 124.30 | test_network.py
    test_delete_account | Success | 273.18 | test_network.py
    test_02_port_fwd_on_non_src_nat | Success | 55.61 | test_network.py
    test_01_port_fwd_on_src_nat | Success | 111.86 | test_network.py
    test_nic_secondaryip_add_remove | Success | 232.59 | test_multipleips_per_nic.py
    login_test_saml_user | Success | 19.09 | test_login.py
    test_assign_and_removal_lb | Success | 133.44 | test_loadbalance.py
    test_02_create_lb_rule_non_nat | Success | 188.10 | test_loadbalance.py
    test_01_create_lb_rule_src_nat | Success | 217.67 | test_loadbalance.py
    test_03_list_snapshots | Success | 0.05 | test_list_ids_parameter.py
    test_02_list_templates | Success | 0.04 | test_list_ids_parameter.py
    test_01_list_volumes | Success | 0.03 | test_list_ids_parameter.py
    test_07_list_default_iso | Success | 0.06 | test_iso.py
    test_05_iso_permissions | Success | 0.06 | test_iso.py
    test_04_extract_Iso | Success | 5.18 | test_iso.py
    test_03_delete_iso | Success | 95.19 | test_iso.py
    test_02_edit_iso | Success | 0.05 | test_iso.py
    test_01_create_iso | Success | 20.96 | test_iso.py
    test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 218.17 | test_internal_lb.py
    test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 152.67 | test_internal_lb.py
    test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 520.17 | test_internal_lb.py
    test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 429.24 | test_internal_lb.py
    test_dedicateGuestVlanRange | Success | 10.24 | test_guest_vlan_range.py
    test_UpdateConfigParamWithScope | Success | 0.12 | test_global_settings.py
    test_rolepermission_lifecycle_update | Success | 6.21 | test_dynamicroles.py
    test_rolepermission_lifecycle_list | Success | 5.96 | test_dynamicroles.py
    test_rolepermission_lifecycle_delete | Success | 5.83 | test_dynamicroles.py
    test_rolepermission_lifecycle_create | Success | 5.85 | test_dynamicroles.py
    test_rolepermission_lifecycle_concurrent_updates | Success | 5.98 | test_dynamicroles.py
    test_role_lifecycle_update_role_inuse | Success | 5.90 | test_dynamicroles.py
    test_role_lifecycle_update | Success | 10.96 | test_dynamicroles.py
    test_role_lifecycle_list | Success | 5.86 | test_dynamicroles.py
    test_role_lifecycle_delete | Success | 10.90 | test_dynamicroles.py
    test_role_lifecycle_create | Success | 5.88 | test_dynamicroles.py
    test_role_inuse_deletion | Success | 5.85 | test_dynamicroles.py
    test_role_account_acls_multiple_mgmt_servers | Success | 8.04 | test_dynamicroles.py
    test_role_account_acls | Success | 8.30 | test_dynamicroles.py
    test_default_role_deletion | Success | 5.99 | test_dynamicroles.py
    test_04_create_fat_type_disk_offering | Success | 0.07 | test_disk_offerings.py
    test_03_delete_disk_offering | Success | 0.04 | test_disk_offerings.py
    test_02_edit_disk_offering | Success | 0.05 | test_disk_offerings.py
    test_02_create_sparse_type_disk_offering | Success | 0.07 | test_disk_offerings.py
    test_01_create_disk_offering | Success | 0.10 | test_disk_offerings.py
    test_deployvm_userdispersing | Success | 20.69 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userconcentrated | Success | 35.69 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_firstfit | Success | 50.72 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userdata_post | Success | 25.66 | test_deploy_vm_with_userdata.py
    test_deployvm_userdata | Success | 56.09 | test_deploy_vm_with_userdata.py
    test_02_deploy_vm_root_resize | Success | 6.08 | test_deploy_vm_root_resize.py
    test_01_deploy_vm_root_resize | Success | 5.96 | test_deploy_vm_root_resize.py
    test_00_deploy_vm_root_resize | Success | 222.44 | test_deploy_vm_root_resize.py
    test_deploy_vm_from_iso | Success | 212.56 | test_deploy_vm_iso.py
    test_DeployVmAntiAffinityGroup | Success | 65.96 | test_affinity_groups.py
    test_03_delete_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
    test_02_revert_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
    test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
    test_01_create_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
    test_06_copy_template | Skipped | 0.00 | test_templates.py
    test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
    test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
    test_01_primary_storage_iscsi | Skipped | 0.03 | test_primary_storage.py
    test_06_copy_iso | Skipped | 0.00 | test_iso.py
    test_deploy_vgpu_enabled_vm | Skipped | 0.00 | test_deploy_vgpu_enabled_vm.py



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---