You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/16 20:02:32 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5760: ESP32-S3: Fix UART IRQ setup hardcoded to CPU 0

gustavonihei commented on a change in pull request #5760:
URL: https://github.com/apache/incubator-nuttx/pull/5760#discussion_r828398043



##########
File path: arch/xtensa/src/esp32s3/esp32s3_serial.c
##########
@@ -1124,7 +1108,7 @@ int up_putc(int ch)
       up_lowputc('\r');
     }
 
-  up_lowputc(ch);
+  up_lowputc((char)ch);

Review comment:
       This is for silencing clang-tidy's *bugprone-narrowing-conversions* warning:
   https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines-narrowing-conversions.html




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org