You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/27 12:26:02 UTC

[GitHub] [airflow] zhongjiajie commented on a change in pull request #7343: [AIRFLOW-6719] Introduce pyupgrade to enforce latest syntax

zhongjiajie commented on a change in pull request #7343: [AIRFLOW-6719] Introduce pyupgrade to enforce latest syntax
URL: https://github.com/apache/airflow/pull/7343#discussion_r385093470
 
 

 ##########
 File path: tests/providers/amazon/aws/operators/test_sftp_to_s3.py
 ##########
 @@ -81,7 +81,7 @@ def test_sftp_to_s3_operation(self):
         create_file_task = SSHOperator(
             task_id="test_create_file",
             ssh_hook=self.hook,
-            command="echo '{0}' > {1}".format(test_remote_file_content,
+            command="echo '{}' > {}".format(test_remote_file_content,
                                               self.sftp_path),
 
 Review comment:
   ```suggestion
                                               self.sftp_path),
   ```
   ```log
   tests/providers/amazon/aws/operators/test_sftp_to_s3.py:85:47: E127 continuation line over-indented for visual indent
   tests/models/test_taskinstance.py:318:45: E128 continuation line under-indented for visual indent
   airflow/ti_deps/deps/runnable_exec_date_dep.py:38:47: E127 continuation line over-indented for visual indent
   tests/providers/sftp/operators/test_sftp.py:214:47: E127 continuation line over-indented for visual indent
   tests/providers/sftp/operators/test_sftp.py:252:47: E127 continuation line over-indented for visual indent
   tests/providers/sftp/operators/test_sftp.py:291:47: E127 continuation line over-indented for visual indent
   tests/providers/sftp/operators/test_sftp.py:327:47: E127 continuation line over-indented for visual indent
   airflow/cli/commands/dag_command.py:85:50: E127 continuation line over-indented for visual indent
   airflow/ti_deps/deps/dag_ti_slots_available_dep.py:33:57: E127 continuation line over-indented for visual indent
   airflow/providers/sftp/operators/sftp.py:139:57: E127 continuation line over-indented for visual indent
   airflow/providers/sftp/operators/sftp.py:150:57: E127 continuation line over-indented for visual indent
   airflow/ti_deps/deps/not_in_retry_period_dep.py:52:41: E127 continuation line over-indented for visual indent
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services