You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/03/22 11:04:21 UTC

[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #5685: Update to arrow 36

tustvold commented on code in PR #5685:
URL: https://github.com/apache/arrow-datafusion/pull/5685#discussion_r1144628553


##########
datafusion/common/src/scalar.rs:
##########
@@ -3437,10 +3437,6 @@ mod tests {
             ScalarValue::Decimal128(None, 10, 2),
             ScalarValue::try_from_array(&array, 3).unwrap()
         );
-        assert_eq!(

Review Comment:
   See https://github.com/apache/arrow-datafusion/pull/5441#discussion_r1121792711
   
   This test was wrong



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org