You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2018/05/12 21:53:42 UTC

[GitHub] storm-site pull request #5: Style tables so they appear similar to how they ...

GitHub user srdo opened a pull request:

    https://github.com/apache/storm-site/pull/5

    Style tables so they appear similar to how they look on Github

    I think the table styling we have right now is hard to read. Compare the table at the bottom of https://storm.apache.org/releases/2.0.0-SNAPSHOT/storm-kafka-client.html with how it appears when shown on Github https://github.com/apache/storm-site/blob/asf-site/releases/2.0.0-SNAPSHOT/storm-kafka-client.md. 
    
    I copied a couple of rules from the styling used by GH, and added a container for documentation content, so the style will only apply to tables in page content.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm-site table-gh-styling

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm-site/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5
    
----
commit b9737c21db9e299a7e396d758faae7b1d4788c0c
Author: Stig Rohde Døssing <st...@...>
Date:   2018-05-12T09:46:31Z

    Style tables so they appear similar to how they look on Github

----


---

[GitHub] storm-site issue #5: Style tables so they appear similar to how they look on...

Posted by erikdw <gi...@git.apache.org>.

Github user erikdw commented on the issue:

    https://github.com/apache/storm-site/pull/5
  
    :shipit: !   Thanks @srdo .    FYI, I hand-hacked my view of the site using Google Chrome's developer tools, and verified that the additions you propose make it look good:
    
    <img width="1435" alt="screenshot 2018-05-14 14 53 48" src="https://user-images.githubusercontent.com/1111441/40030501-a4daa4fa-5786-11e8-8039-b9fca9dbb9cc.png">



---

[GitHub] storm-site issue #5: Style tables so they appear similar to how they look on...

Posted by srdo <gi...@git.apache.org>.

Github user srdo commented on the issue:

    https://github.com/apache/storm-site/pull/5
  
    Thanks for the reviews, I'll merge and push this to the site.
    
    @erikdw I probably should have thought to include a screenshot, thanks :)


---

[GitHub] storm-site pull request #5: Style tables so they appear similar to how they ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm-site/pull/5


---