[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1837: Return `Error` when parquet reader fails rather than no data with `println!`

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #1837:
URL: https://github.com/apache/arrow-datafusion/pull/1837#discussion_r807328426



##########
File path: datafusion/src/physical_plan/file_format/parquet.rs
##########
@@ -808,18 +822,8 @@ mod tests {
         let read =
             round_trip_to_parquet(vec![batch1, batch2], None, Some(Arc::new(schema)))
                 .await;
-
-        // expect only the first batch to be read
-        let expected = vec![
-            "+-----+----+----+",
-            "| c1  | c2 | c3 |",
-            "+-----+----+----+",
-            "| Foo | 1  | 10 |",
-            "|     | 2  | 20 |",
-            "| bar |    |    |",
-            "+-----+----+----+",
-        ];
-        assert_batches_sorted_eq!(expected, &read);
+        assert_contains!(read.unwrap_err().to_string(),

Review comment:
       This test should have always failed -- see https://github.com/apache/arrow-datafusion/pull/1622#discussion_r790137450




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org