You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by jiangxb1987 <gi...@git.apache.org> on 2018/01/19 23:48:52 UTC

[GitHub] spark pull request #20046: [SPARK-22362][SQL] Add unit test for Window Aggre...

Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20046#discussion_r162759216
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFunctionsSuite.scala ---
    @@ -86,6 +93,429 @@ class DataFrameWindowFunctionsSuite extends QueryTest with SharedSQLContext {
         assert(e.message.contains("requires window to be ordered"))
       }
     
    +  test("aggregation and rows between") {
    +    val df = Seq((1, "1"), (2, "1"), (2, "2"), (1, "1"), (2, "2")).toDF("key", "value")
    --- End diff --
    
    We shall also include null data.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org